lukechilds/node - node - Gitea: Git with a cup of tea

11440 Commits

131 Branches

446 Tags

325 MiB

Tree: e67542ae17

Commit Graph

Author	SHA1	Message	Date
Roman Reiss	2e2fce0502	repl: fix persistent history and env variable name Issue #1575 did introduce a check for options.terminal but this variable wasn't able to get truthy, which in turn broke persistent history completely. This changes the variable to get truthy on true terminals. Additionally, the docs and the code did differ on which environment variable was used for history. This changes the code to use NODE_REPL_HISTORY_FILE. PR-URL: https://github.com/iojs/io.js/pull/1593 Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>	10 years ago
Fedor Indutny	ea5195ccaf	repl: do not save history for non-terminal repl When running in non-TTY mode - the `repl.history` is `undefined` and is not actually populated. Saving it will result in a crashes of subsequent repl runs. Fix: https://github.com/iojs/io.js/issues/1574 PR-URL: https://github.com/iojs/io.js/pull/1575 Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>	10 years ago
Chris Dickinson	0450ce7db2	repl: add mode detection, cli persistent history this creates a new internal module responsible for providing the repl created via "iojs" or "iojs -i," and adds the following options to the readline and repl subsystems: * "repl mode" - determine whether a repl is strict mode, sloppy mode, or auto-detect mode. * historySize - determine the maximum number of lines a repl will store as history. The built-in repl gains persistent history support when the NODE_REPL_HISTORY_FILE environment variable is set. This functionality is not exposed to userland repl instances. PR-URL: https://github.com/iojs/io.js/pull/1513 Reviewed-By: Fedor Indutny <fedor@indutny.com>	10 years ago

Author

SHA1

Message

Date

Roman Reiss

2e2fce0502

repl: fix persistent history and env variable name

Issue #1575 did introduce a check for options.terminal but this variable
wasn't able to get truthy, which in turn broke persistent history
completely. This changes the variable to get truthy on true terminals.

Additionally, the docs and the code did differ on which environment
variable was used for history. This changes the code to use
NODE_REPL_HISTORY_FILE.

PR-URL: https://github.com/iojs/io.js/pull/1593
Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>

10 years ago

Fedor Indutny

ea5195ccaf

repl: do not save history for non-terminal repl

When running in non-TTY mode - the `repl.history` is `undefined` and
is not actually populated. Saving it will result in a crashes of
subsequent repl runs.

Fix: https://github.com/iojs/io.js/issues/1574
PR-URL: https://github.com/iojs/io.js/pull/1575
Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>

10 years ago

Chris Dickinson

0450ce7db2

repl: add mode detection, cli persistent history

this creates a new internal module responsible for providing
the repl created via "iojs" or "iojs -i," and adds the following
options to the readline and repl subsystems:

* "repl mode" - determine whether a repl is strict mode, sloppy mode,
  or auto-detect mode.
* historySize - determine the maximum number of lines a repl will store
  as history.

The built-in repl gains persistent history support when the
NODE_REPL_HISTORY_FILE environment variable is set. This functionality
is not exposed to userland repl instances.

PR-URL: https://github.com/iojs/io.js/pull/1513
Reviewed-By: Fedor Indutny <fedor@indutny.com>

10 years ago

3 Commits (e67542ae17510e3657c2a946fde3dee4d775ac88)