lukechilds/node - node - Gitea: Git with a cup of tea

12909 Commits

131 Branches

446 Tags

325 MiB

Tree: ec8e0ae697

Commit Graph

Author	SHA1	Message	Date
Roman Reiss	f29762f4dd	test: enable linting for tests Enable linting for the test directory. A number of changes was made so all tests conform the current rules used by lib and src directories. The only exception for tests is that unreachable (dead) code is allowed. test-fs-non-number-arguments-throw had to be excluded from the changes because of a weird issue on Windows CI. PR-URL: https://github.com/nodejs/io.js/pull/1721 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>	10 years ago
Shigeki Ohtsu	6ccbe75384	js_stream: fix buffer index in DoWrite The index of buffer to write in JSStream was always 0 by mistake. This fix was to use increment index of buffer arrays. The test was originally made by Brian White in #1594. Fix: https://github.com/iojs/io.js/issues/1595 Fix: https://github.com/iojs/io.js/pull/1594 PR-URL: https://github.com/iojs/io.js/pull/1635 Reviewed-By: Fedor Indutny <fedor@indutny.com>	10 years ago

Author

SHA1

Message

Date

Roman Reiss

f29762f4dd

test: enable linting for tests

Enable linting for the test directory. A number of changes was made so
all tests conform the current rules used by lib and src directories. The
only exception for tests is that unreachable (dead) code is allowed.

test-fs-non-number-arguments-throw had to be excluded from the changes
because of a weird issue on Windows CI.

PR-URL: https://github.com/nodejs/io.js/pull/1721
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

10 years ago

Shigeki Ohtsu

6ccbe75384

js_stream: fix buffer index in DoWrite

The index of buffer to write in JSStream was always 0 by mistake. This
fix was to use increment index of buffer arrays.
The test was originally made by Brian White in #1594.

Fix: https://github.com/iojs/io.js/issues/1595
Fix: https://github.com/iojs/io.js/pull/1594
PR-URL: https://github.com/iojs/io.js/pull/1635
Reviewed-By: Fedor Indutny <fedor@indutny.com>

10 years ago

2 Commits (ec8e0ae697d96c417bda0bbe5be9712cf5923b1f)