lukechilds/node - node - Gitea: Git with a cup of tea

14187 Commits

131 Branches

446 Tags

325 MiB

Tree: ec90a7a92e

Commit Graph

Author	SHA1	Message	Date
Rich Trott	d74062454b	test: make stdout buffer test more robust test-stdout-buffer-flush-on-exit is unfortunately non-deterministic. It will, every so often, pass when it is supposed to fail. This is currently guarded against by running the test with three different long strings. This change increases it to five to reduce the false negatives. PR-URL: https://github.com/nodejs/node/pull/6633 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>	9 years ago
Rich Trott	83dab801e2	test: fix unreliable known_issues test `test-stdout-buffer-flush-on-exit` was not failing reliably on POSIX machines and not failing at all on Windows. Revised test fails reliably on POSIX and is skipped (in CI) on Windows where the issue does not exist. Fixes: https://github.com/nodejs/node/issues/6527 PR-URL: https://github.com/nodejs/node/pull/6555 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joao Reis <reis@janeasystems.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>	9 years ago
Rich Trott	33c27f8fcf	test: add known_issues test for GH-2148 PR-URL: https://github.com/nodejs/node/pull/5920 Refs: https://github.com/nodejs/node/issues/2148 Reviewed-By: Brian White <mscdex@mscdex.net>	9 years ago

Author

SHA1

Message

Date

Rich Trott

d74062454b

test: make stdout buffer test more robust

test-stdout-buffer-flush-on-exit is unfortunately non-deterministic. It
will, every so often, pass when it is supposed to fail. This is
currently guarded against by running the test with three different long
strings. This change increases it to five to reduce the false negatives.

PR-URL: https://github.com/nodejs/node/pull/6633
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

9 years ago

Rich Trott

83dab801e2

test: fix unreliable known_issues test

`test-stdout-buffer-flush-on-exit` was not failing reliably on POSIX
machines and not failing at all on Windows. Revised test fails reliably
on POSIX and is skipped (in CI) on Windows where the issue does not
exist.

Fixes: https://github.com/nodejs/node/issues/6527
PR-URL: https://github.com/nodejs/node/pull/6555
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joao Reis <reis@janeasystems.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

9 years ago

Rich Trott

33c27f8fcf

test: add known_issues test for GH-2148

PR-URL: https://github.com/nodejs/node/pull/5920
Refs: https://github.com/nodejs/node/issues/2148
Reviewed-By: Brian White <mscdex@mscdex.net>

9 years ago

3 Commits (ec90a7a92e03aa86f210707580668ccb02037924)