lukechilds/node - node - Gitea: Git with a cup of tea

16565 Commits

131 Branches

446 Tags

325 MiB

Tree: f3c0b8cd6e

Commit Graph

Author	SHA1	Message	Date
Rich Trott	34fc7a03d2	test: change deprecated method to recommended In non-buffer tests, change usage of the Buffer constructor to one of the recommended alternatives. Backport-PR-URL: https://github.com/nodejs/node/pull/14339 PR-URL: https://github.com/nodejs/node/pull/13649 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Brian White <mscdex@mscdex.net>	8 years ago
Gibson Fahnestock	db61c952de	test: use eslint to fix var->const/let Manually fix issues that eslint --fix couldn't do automatically. Backport-PR-URL: https://github.com/nodejs/node/pull/11775 PR-URL: https://github.com/nodejs/node/pull/10685 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>	8 years ago
Brian White	92212014ff	stream: fix no data on partial decode Before this commit, it was possible to push a partial character to a readable stream where it was decoded as an empty string and then added to the internal buffer. This caused the stream to not emit any data, even when the rest of the character bytes were pushed separately, because of a non-zero length check of the first chunk in the internal buffer. Fixes: https://github.com/nodejs/node/issues/5223 PR-URL: https://github.com/nodejs/node/pull/5226 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>	9 years ago

Author

SHA1

Message

Date

Rich Trott

34fc7a03d2

test: change deprecated method to recommended

In non-buffer tests, change usage of the Buffer constructor to one of
the recommended alternatives.

Backport-PR-URL: https://github.com/nodejs/node/pull/14339
PR-URL: https://github.com/nodejs/node/pull/13649
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Brian White <mscdex@mscdex.net>

8 years ago

Gibson Fahnestock

db61c952de

test: use eslint to fix var->const/let

Manually fix issues that eslint --fix couldn't do automatically.

Backport-PR-URL: https://github.com/nodejs/node/pull/11775
PR-URL: https://github.com/nodejs/node/pull/10685
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>

8 years ago

Brian White

92212014ff

stream: fix no data on partial decode

Before this commit, it was possible to push a partial character
to a readable stream where it was decoded as an empty string and
then added to the internal buffer. This caused the stream to not
emit any data, even when the rest of the character bytes were pushed
separately, because of a non-zero length check of the first chunk in
the internal buffer.

Fixes: https://github.com/nodejs/node/issues/5223
PR-URL: https://github.com/nodejs/node/pull/5226
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

9 years ago

3 Commits (f3c0b8cd6ea6b653656656648f77d2dd248dc22c)