lukechilds/node - node - Gitea: Git with a cup of tea

Author	SHA1	Message	Date
Anna Henningsen	c80d400c01	Revert "test: disable MultipleEnvironmentsPerIsolate" This reverts commit `95ab966a74`. Ref: https://github.com/nodejs/node/issues/14206 Ref: https://github.com/nodejs/node/pull/14246 PR-URL: https://github.com/nodejs/node/pull/14749 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>	7 years ago
Anna Henningsen	ef7da4200d	Revert "test: add DISABLED_ prefix to commented out test" This reverts commit `75bf8a9db9`. Ref: https://github.com/nodejs/node/issues/14206 Ref: https://github.com/nodejs/node/pull/14317 PR-URL: https://github.com/nodejs/node/pull/14749 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>	7 years ago
Anna Henningsen	93f25f4b44	test: properly order freeing resources in cctest The `IsolateData` instance is created before the `Environment` instance, so free in reverse order. Fixes: https://github.com/nodejs/node/issues/14206 PR-URL: https://github.com/nodejs/node/pull/14749 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>	7 years ago
Daniel Bevenius	75bf8a9db9	test: add DISABLED_ prefix to commented out test Commit `95ab966a74` ("test: disable MultipleEnvironmentsPerIsolate") commented out MultipleEnvironmentsPerIsolate but it migth be better to disable the test so that this gets reported and not forgotten: YOU HAVE 1 DISABLED TEST PR-URL: https://github.com/nodejs/node/pull/14317 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>	8 years ago
Refael Ackermann	95ab966a74	test: disable MultipleEnvironmentsPerIsolate This is a temporary measure until the issue is fixed. PR-URL: https://github.com/nodejs/node/pull/14246 Refs: https://github.com/nodejs/node/issues/14206 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>	8 years ago
Anna Henningsen	d5db4d25dc	test: cleanup handles in test_environment The test fixtures create multiple node::Environments that all use the uv_default_loop(), and since the test does not clean up the handles created by Environment::Start(), the default libuv loop structure contains dangling pointers after the first Environment is freed, which then means that creating new handles leads to memory corruption. PR-URL: https://github.com/nodejs/node/pull/12621 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>	8 years ago
Daniel Bevenius	ec53921d2e	src: make AtExit callback's per Environment This commit attempts to address one of the TODOs in https://github.com/nodejs/node/issues/4641 regarding making the AtExit callback's per environment, instead of the current global. bnoordhuis provided a few options for solving this, and one was to use a thread-local which is what this commit attempts to do. PR-URL: https://github.com/nodejs/node/pull/9163 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>	8 years ago