lukechilds/node - node - Gitea: Git with a cup of tea

18743 Commits

131 Branches

446 Tags

325 MiB

Tree: fc1fa4e2c4

Commit Graph

Author	SHA1	Message	Date
Gabriel Schulhof	78286984da	test,doc: make module name match gyp target name Currently the nm_modname does not match the file name of the resulting module. In fact, the nm_modname is pretty arbitrary. This seeks to introduce some consistency into the nm_modname property by having the name of the module appear in exactly one place: the "target_name" property of the gyp target that builds the module. PR-URL: https://github.com/nodejs/node/pull/15209 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>	8 years ago
Gabriel Schulhof	9926dfebc8	n-api: re-use napi_env between modules Store the `napi_env` on the global object at a private key. This gives us one `napi_env` per context. Refs: https://github.com/nodejs/node/issues/14367 PR-URL: https://github.com/nodejs/node/pull/14217 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Timothy Gu <timothygu99@gmail.com>	8 years ago

Author

SHA1

Message

Date

Gabriel Schulhof

78286984da

test,doc: make module name match gyp target name

Currently the nm_modname does not match the file name of the resulting
module. In fact, the nm_modname is pretty arbitrary. This seeks to
introduce some consistency into the nm_modname property by having the
name of the module appear in exactly one place: the "target_name"
property of the gyp target that builds the module.

PR-URL: https://github.com/nodejs/node/pull/15209
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

8 years ago

Gabriel Schulhof

9926dfebc8

n-api: re-use napi_env between modules

Store the `napi_env` on the global object at a private key. This gives
us one `napi_env` per context.

Refs: https://github.com/nodejs/node/issues/14367
PR-URL: https://github.com/nodejs/node/pull/14217
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>

8 years ago

2 Commits (fc1fa4e2c49aa060b97b139ff02b5be8037dba94)