lukechilds/node - node - Gitea: Git with a cup of tea

Author	SHA1	Message	Date
Trevor Norris	2cad7a69ce	buffer: throw when writing beyond buffer Previously one could write anywhere in a buffer pool if they accidently got their offset wrong. Mainly because the cc level checks only test against the parent slow buffer and not against the js object properties. So now we check to make sure values won't go beyond bounds without letting the dev know.	12 years ago
Trevor Norris	d5d5170c35	string_bytes: strip padding from base64 strings Because of variations in different base64 implementation, it's been decided to strip all padding from the end of a base64 string and calculate its size from that.	12 years ago
Ben Noordhuis	f59ab10a64	buffer, crypto: fix default encoding regression The default encoding is 'buffer'. When the input is a string, treat it as 'binary'. Fixes the following assertion: node: ../src/string_bytes.cc:309: static size_t node::StringBytes::StorageSize(v8::Handle<v8::Value>, node::encoding): Assertion `0 && "buffer encoding specified but string provided"' failed. Introduced in `64fc34b2`. Fixes #5482.	12 years ago
Łukasz Walukiewicz	2e28832660	buffer: fix offset checks Fixed offset checks in Buffer.readInt32LE() and Buffer.readInt32BE() functions.	12 years ago
Ben Noordhuis	3f7e88a852	buffer: accept negative indices in Buffer#slice() A negative start or end parameter now indexes from the end of the buffer. More in line with String#slice() and ArrayBuffer#slice().	12 years ago
Trevor Norris	65249ccd9b	buffer: slow buffer copy compatibility fix Fix issue where SlowBuffers couldn't be passed as target to Buffer copy(). Also included checks to see if Argument parameters are defined before assigning their values. This offered ~3x's performance gain. Backport of `16bbecc` from master branch. Closes #4633.	12 years ago
Trevor Norris	49175e6ae2	buffer: clean up copy() asserts and tests Argument checks were simplified by setting all undefined/NaN or out of bounds values equal to their defaults. Also copy() tests had a flaw that each buffer had the same bit pattern at the same offset. So even if the copy failed, the bit-by-bit comparison would have still been true. This was fixed by filling each buffer with a unique value before copy operations.	12 years ago
Trevor Norris	16bbeccd40	buffer: slow buffer copy compatibility fix Fix issue where SlowBuffers couldn't be passed as target to Buffer copy(). Also included checks to see if Argument parameters are defined before assigning their values. This offered ~3x's performance gain.	12 years ago
Ben Noordhuis	498200b87c	buffer: reject negative SlowBuffer offsets Reject negative offsets in SlowBuffer::MakeFastBuffer(), it allows the creation of buffers that point to arbitrary addresses. Reported by Trevor Norris.	12 years ago
Trevor Norris	22b84e6216	buffer: floating point read/write improvements Improvements: * floating point operations are approx 4x's faster * Now write quiet NaN's * all read/write on floating point now done in C, so no more need for lib/buffer_ieee754.js * float values have more accurate min/max value checks * add additional benchmarks for buffers read/write * created benchmark/_bench_timer.js which is a simple library that can be included into any benchmark and provides an intelligent tracker for sync and async tests * add benchmarks for DataView set methods * add checks and tests to make sure offset is greater than 0	12 years ago
Ben Noordhuis	9668df8b39	v8: work around String::WriteAscii segfault See http://code.google.com/p/v8/issues/detail?id=2493 for details. Once the patch lands in upstream V8, this commit can be reverted.	12 years ago
Trevor Norris	6772308883	buffer: Don't double-negate numeric buffer arg Fix #4331 Using double negate forces values into 32bit space. Because of this Math.ceil needs to be used. Since NaN comparisons are always false, use that to our advantage to return 0 if it is. Also added two tests to verify the changes.	12 years ago
Ricky Ng-Adam	8bd4590a31	buffer: include encoding value in exception when invalid Encoding failures can be somewhat confusing, especially when they are due to control flow frameworks auto-filling parameters from the previous step output values to functions (such as toString and write) that developers don't expect to take an encoding parameter. By outputting the value as part of the message, should make it easier to track down these sort of bugs.	12 years ago
koichik	fbb0ee6f24	buffer: fix byteLength with UTF-16LE Fixes #4075.	12 years ago
Nathan Rajlich	a4ef01df07	buffer: implement Buffer.prototype.toJSON() Returns an Array-representation of the Buffer. Closes #3905.	12 years ago
isaacs	05282588e0	Buffer.isEncoding(enc) Re: #3918	12 years ago
Karl Skomski	57d53a47e8	Use parent SlowBuffer, if any, when Buffer is sliced Closes #3416 Closes #3477	13 years ago
koichik	ebbd4039bc	buffer: add UTF-16LE encoding name.	13 years ago
Ben Noordhuis	b9127eb0a5	buffer: support decoding of URL-safe base64	13 years ago
Ben Noordhuis	f101f7c9ba	buffers: honor length argument in base64 decoder Honor the length argument in `buf.write(s, 0, buf.length, 'base64')`. Before this commit, the length argument was ignored. The decoder would keep writing until it hit the end of the buffer. Since most buffers in Node are slices of a parent buffer (the slab), this bug would overwrite the content of adjacent buffers. The bug is trivially demonstrated with the following test case: var assert = require('assert'); var a = Buffer(3); var b = Buffer('xxx'); a.write('aaaaaaaa', 'base64'); assert.equal(b.toString(), 'xxx'); This commit coincidentally also fixes a bug where Buffer._charsWritten was not updated for zero length buffers.	13 years ago
Ryan Dahl	d77ce4b998	Fixes #1860 . Remove process.writeError Breaks a few tests in "make test-message"	13 years ago
Colton Baker	87286cc737	Fixed a lot of jslint errors. Fixes #1831	13 years ago
Ben Noordhuis	f6bce20e5e	buffers: handle bad length argument in constructor Coerce fractional, negative and non-numeric length arguments to numbers. Fractional numbers are rounded up, negative numbers and non-numeric values are set to zero.	13 years ago
Ben Noordhuis	d157131439	buffers: handle bad length argument in constructor Coerce fractional, negative and non-numeric length arguments to numbers. Fractional numbers are rounded up, negative numbers and non-numeric values are set to zero.	13 years ago
koichik	3e853e627e	buffer: write() should always set _charsWritten. Refs #1633.	13 years ago
koichik	96ede8cc9b	buffer: Avoid overrun with 'binary' encoding. Fixes #1624.	13 years ago
koichik	526c54c979	buffer: write() should always set _charsWritten. Fixes #1633.	13 years ago
koichik	50e147bd03	Add an optional length argument to Buffer.write() Fixes #243. Fixes #1361.	13 years ago
koichik	5208abe723	Fix Buffer drops last null character in UTF-8 Reproduce: $ node > buf = new Buffer('\0') <Buffer > > buf.length 0 > buf = new Buffer(1) <Buffer 28> > buf.write('\0') 0 Fixes #394. Fixes #1210.	14 years ago
Ben Noordhuis	8e0d788842	Test for #402 : writing base64 at position > 0 should not mangle the result. This is a regression test, the bug itself was fixed in v0.3.x.	14 years ago
Ryan Dahl	6461af1baa	Fix buffer test	14 years ago
Ryan Dahl	5e409c2f1a	makeFastBuffer should not segfault but rather throw on non-buffer	14 years ago
Ryan Dahl	103a450d3a	Remove 'binary' encoding assert - add tests Don't write large characters to buffers with binary encoding. You will be silently injured.	14 years ago
Konstantin Käfer	5e1b7cadb4	Add Buffer::fill method to do memset Fixes #477.	14 years ago
koichik	fcc04e67c8	Fix SlowBuffer.write() with 'ucs2' throws ReferenceError.	14 years ago
koichik	9533e879f0	Fix Buffer.write() with UCS-2 should not be write partial char closes #916.	14 years ago
Ryan Dahl	038306a6c3	Closes GH-843. Fix SlowBuffer.prototype.slice	14 years ago
isaacs	3c9fb3ec1a	Fix invalid end handling for SlowBuffer#hexSlice	14 years ago
Ryan Dahl	55048cdf79	Update copyright headers	14 years ago
isaacs	0aa1a8a005	Closes GH-695 Add 'hex' encoding to Buffer	14 years ago
Ryan Dahl	0474ce6790	Revert "buffer.toString() shouldn't include null values" This reverts commit `909a5b39d2`. Will fix inside V8's String::New instead.	14 years ago
Ryan Dahl	909a5b39d2	buffer.toString() shouldn't include null values	14 years ago
isaacs	2e6a263e29	Closes GH-609 Support array-ish args to Buffer ctor Any array-ish thing (whether a Buffer, an Array, or just an object with a numeric "length") is interpreted as a list of bytes.	14 years ago
Konstantin Käfer	9e101f2b01	UCS-2 support Closes GH-644.	14 years ago
Tom Hughes	0d58353d66	Don't access buffer data before initializing it. Prevents valgrind from complaining and still tests that buffer data is treated as unsigned.	14 years ago
Oleg Efimov	0665f0271e	GJSLint all simple tests exclude http-*, url, path	14 years ago
Ryan Dahl	fbdff52b44	Fix global leaks in test-buffer.js	14 years ago
Ryan Dahl	4f32a59307	Fix buffer.slice(0, 0)	14 years ago
Jorge Chamorro Bieling	c735b4663a	unbase64 skips over any illegal chars	14 years ago
Ryan Dahl	cf1db4f304	base64 decode should handle whitespace	14 years ago

1 2