// Copyright 2014 the V8 project authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. #include "src/compiler/js-builtin-reducer.h" #include "src/compiler/js-graph.h" #include "src/compiler/node-properties-inl.h" #include "src/compiler/typer.h" #include "test/unittests/compiler/graph-unittest.h" #include "test/unittests/compiler/node-test-utils.h" #include "testing/gmock-support.h" using testing::Capture; namespace v8 { namespace internal { namespace compiler { class JSBuiltinReducerTest : public TypedGraphTest { public: JSBuiltinReducerTest() : javascript_(zone()) {} protected: Reduction Reduce(Node* node, MachineOperatorBuilder::Flags flags = MachineOperatorBuilder::Flag::kNoFlags) { MachineOperatorBuilder machine(zone(), kMachPtr, flags); JSGraph jsgraph(graph(), common(), javascript(), &machine); JSBuiltinReducer reducer(&jsgraph); return reducer.Reduce(node); } Handle MathFunction(const char* name) { Handle m = JSObject::GetProperty(isolate()->global_object(), isolate()->factory()->NewStringFromAsciiChecked( "Math")).ToHandleChecked(); Handle f = Handle::cast( JSObject::GetProperty( m, isolate()->factory()->NewStringFromAsciiChecked(name)) .ToHandleChecked()); return f; } JSOperatorBuilder* javascript() { return &javascript_; } private: JSOperatorBuilder javascript_; }; namespace { // TODO(mstarzinger): Find a common place and unify with test-js-typed-lowering. Type* const kNumberTypes[] = { Type::UnsignedSmall(), Type::NegativeSigned32(), Type::NonNegativeSigned32(), Type::SignedSmall(), Type::Signed32(), Type::Unsigned32(), Type::Integral32(), Type::MinusZero(), Type::NaN(), Type::OrderedNumber(), Type::PlainNumber(), Type::Number()}; } // namespace // ----------------------------------------------------------------------------- // Math.abs TEST_F(JSBuiltinReducerTest, MathAbs) { Handle f = MathFunction("abs"); TRACED_FOREACH(Type*, t0, kNumberTypes) { Node* p0 = Parameter(t0, 0); Node* fun = HeapConstant(Unique::CreateUninitialized(f)); Node* call = graph()->NewNode(javascript()->CallFunction(3, NO_CALL_FUNCTION_FLAGS), fun, UndefinedConstant(), p0); Reduction r = Reduce(call); if (t0->Is(Type::Unsigned32())) { ASSERT_TRUE(r.Changed()); EXPECT_THAT(r.replacement(), p0); } else { Capture branch; ASSERT_TRUE(r.Changed()); EXPECT_THAT(r.replacement(), IsSelect(kMachNone, IsNumberLessThan(IsNumberConstant(0), p0), p0, IsNumberSubtract(IsNumberConstant(0), p0))); } } } // ----------------------------------------------------------------------------- // Math.sqrt TEST_F(JSBuiltinReducerTest, MathSqrt) { Handle f = MathFunction("sqrt"); TRACED_FOREACH(Type*, t0, kNumberTypes) { Node* p0 = Parameter(t0, 0); Node* fun = HeapConstant(Unique::CreateUninitialized(f)); Node* call = graph()->NewNode(javascript()->CallFunction(3, NO_CALL_FUNCTION_FLAGS), fun, UndefinedConstant(), p0); Reduction r = Reduce(call); ASSERT_TRUE(r.Changed()); EXPECT_THAT(r.replacement(), IsFloat64Sqrt(p0)); } } // ----------------------------------------------------------------------------- // Math.max TEST_F(JSBuiltinReducerTest, MathMax0) { Handle f = MathFunction("max"); Node* fun = HeapConstant(Unique::CreateUninitialized(f)); Node* call = graph()->NewNode(javascript()->CallFunction(2, NO_CALL_FUNCTION_FLAGS), fun, UndefinedConstant()); Reduction r = Reduce(call); ASSERT_TRUE(r.Changed()); EXPECT_THAT(r.replacement(), IsNumberConstant(-V8_INFINITY)); } TEST_F(JSBuiltinReducerTest, MathMax1) { Handle f = MathFunction("max"); TRACED_FOREACH(Type*, t0, kNumberTypes) { Node* p0 = Parameter(t0, 0); Node* fun = HeapConstant(Unique::CreateUninitialized(f)); Node* call = graph()->NewNode(javascript()->CallFunction(3, NO_CALL_FUNCTION_FLAGS), fun, UndefinedConstant(), p0); Reduction r = Reduce(call); ASSERT_TRUE(r.Changed()); EXPECT_THAT(r.replacement(), p0); } } TEST_F(JSBuiltinReducerTest, MathMax2) { Handle f = MathFunction("max"); TRACED_FOREACH(Type*, t0, kNumberTypes) { TRACED_FOREACH(Type*, t1, kNumberTypes) { Node* p0 = Parameter(t0, 0); Node* p1 = Parameter(t1, 1); Node* fun = HeapConstant(Unique::CreateUninitialized(f)); Node* call = graph()->NewNode( javascript()->CallFunction(4, NO_CALL_FUNCTION_FLAGS), fun, UndefinedConstant(), p0, p1); Reduction r = Reduce(call); if (t0->Is(Type::Integral32()) && t1->Is(Type::Integral32())) { ASSERT_TRUE(r.Changed()); EXPECT_THAT(r.replacement(), IsSelect(kMachNone, IsNumberLessThan(p1, p0), p1, p0)); } else { ASSERT_FALSE(r.Changed()); EXPECT_EQ(IrOpcode::kJSCallFunction, call->opcode()); } } } } // ----------------------------------------------------------------------------- // Math.imul TEST_F(JSBuiltinReducerTest, MathImul) { Handle f = MathFunction("imul"); TRACED_FOREACH(Type*, t0, kNumberTypes) { TRACED_FOREACH(Type*, t1, kNumberTypes) { Node* p0 = Parameter(t0, 0); Node* p1 = Parameter(t1, 1); Node* fun = HeapConstant(Unique::CreateUninitialized(f)); Node* call = graph()->NewNode( javascript()->CallFunction(4, NO_CALL_FUNCTION_FLAGS), fun, UndefinedConstant(), p0, p1); Reduction r = Reduce(call); if (t0->Is(Type::Integral32()) && t1->Is(Type::Integral32())) { ASSERT_TRUE(r.Changed()); EXPECT_THAT(r.replacement(), IsInt32Mul(p0, p1)); } else { ASSERT_FALSE(r.Changed()); EXPECT_EQ(IrOpcode::kJSCallFunction, call->opcode()); } } } } // ----------------------------------------------------------------------------- // Math.fround TEST_F(JSBuiltinReducerTest, MathFround) { Handle f = MathFunction("fround"); TRACED_FOREACH(Type*, t0, kNumberTypes) { Node* p0 = Parameter(t0, 0); Node* fun = HeapConstant(Unique::CreateUninitialized(f)); Node* call = graph()->NewNode(javascript()->CallFunction(3, NO_CALL_FUNCTION_FLAGS), fun, UndefinedConstant(), p0); Reduction r = Reduce(call); ASSERT_TRUE(r.Changed()); EXPECT_THAT(r.replacement(), IsTruncateFloat64ToFloat32(p0)); } } // ----------------------------------------------------------------------------- // Math.floor TEST_F(JSBuiltinReducerTest, MathFloorAvailable) { Handle f = MathFunction("floor"); TRACED_FOREACH(Type*, t0, kNumberTypes) { Node* p0 = Parameter(t0, 0); Node* fun = HeapConstant(Unique::CreateUninitialized(f)); Node* call = graph()->NewNode(javascript()->CallFunction(3, NO_CALL_FUNCTION_FLAGS), fun, UndefinedConstant(), p0); Reduction r = Reduce(call, MachineOperatorBuilder::Flag::kFloat64Floor); ASSERT_TRUE(r.Changed()); EXPECT_THAT(r.replacement(), IsFloat64Floor(p0)); } } TEST_F(JSBuiltinReducerTest, MathFloorUnavailable) { Handle f = MathFunction("floor"); TRACED_FOREACH(Type*, t0, kNumberTypes) { Node* p0 = Parameter(t0, 0); Node* fun = HeapConstant(Unique::CreateUninitialized(f)); Node* call = graph()->NewNode(javascript()->CallFunction(3, NO_CALL_FUNCTION_FLAGS), fun, UndefinedConstant(), p0); Reduction r = Reduce(call, MachineOperatorBuilder::Flag::kNoFlags); ASSERT_FALSE(r.Changed()); } } // ----------------------------------------------------------------------------- // Math.ceil TEST_F(JSBuiltinReducerTest, MathCeilAvailable) { Handle f = MathFunction("ceil"); TRACED_FOREACH(Type*, t0, kNumberTypes) { Node* p0 = Parameter(t0, 0); Node* fun = HeapConstant(Unique::CreateUninitialized(f)); Node* call = graph()->NewNode(javascript()->CallFunction(3, NO_CALL_FUNCTION_FLAGS), fun, UndefinedConstant(), p0); Reduction r = Reduce(call, MachineOperatorBuilder::Flag::kFloat64Ceil); ASSERT_TRUE(r.Changed()); EXPECT_THAT(r.replacement(), IsFloat64Ceil(p0)); } } TEST_F(JSBuiltinReducerTest, MathCeilUnavailable) { Handle f = MathFunction("ceil"); TRACED_FOREACH(Type*, t0, kNumberTypes) { Node* p0 = Parameter(t0, 0); Node* fun = HeapConstant(Unique::CreateUninitialized(f)); Node* call = graph()->NewNode(javascript()->CallFunction(3, NO_CALL_FUNCTION_FLAGS), fun, UndefinedConstant(), p0); Reduction r = Reduce(call, MachineOperatorBuilder::Flag::kNoFlags); ASSERT_FALSE(r.Changed()); } } } // namespace compiler } // namespace internal } // namespace v8