lukechilds/node - node - Gitea: Git with a cup of tea

Tree: 1640e7a4da

Eugene Ostroukhov 250a380231 inspector: simplify buffer management This change simplifies buffer management to address a number of issues that original implementation had. Original implementation was trying to reduce the number of allocations by providing regions of the internal buffer to libuv IO code. This introduced some potential use after free issues if the buffer grows (or shrinks) while there's a pending read. It also had some confusing math that resulted in issues on Windows version of the libuv. PR-URL: https://github.com/nodejs/node/pull/8257 Fixes: https://github.com/nodejs/node/issues/8155 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>	8 years ago
..
test_inspector_socket.cc	inspector: simplify buffer management	8 years ago
util.cc	src: make Sec-WebSocket-Key check case-insensitive	9 years ago

Eugene Ostroukhov 250a380231 inspector: simplify buffer management

This change simplifies buffer management to address a number of issues
that original implementation had.

Original implementation was trying to reduce the number of allocations
by providing regions of the internal buffer to libuv IO code. This
introduced some potential use after free issues if the buffer grows
(or shrinks) while there's a pending read. It also had some confusing
math that resulted in issues on Windows version of the libuv.

PR-URL: https://github.com/nodejs/node/pull/8257
Fixes: https://github.com/nodejs/node/issues/8155
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>

8 years ago

test_inspector_socket.cc

inspector: simplify buffer management

8 years ago

util.cc

src: make Sec-WebSocket-Key check case-insensitive

9 years ago