lukechilds/node - node - Gitea: Git with a cup of tea

History

Sam Roberts f76722686b test: use assert.throw to test exceptions The test wasn't checking directly that an assertion was thrown. Instead, it was checking that spawn did not sucessfully spawn a non-existent command. However, the command chosen, dir, exists in GNU coreutils, so it exists on Linux (though not on BSD derived OS X). The test as written passed on Linux, even with the TypeError it is supposed to be checking for deleted from spawn(). It would also pass on Windows if a ls.exe existed. The approach is unnecessarily obscure, assert.throw() is for asserting code throws, using it is more clear and works regardless of what commands do or do not exist. PR-URL: https://github.com/joyent/node/pull/8454 Reviewed-by: Trevor Norris <trev.norris@gmail.com> Cherry-picked-from: `2ff29cc7e3` Conflicts: test/parallel/test-child-process-spawn-typeerror.js		10 years ago
..
addons	Remove excessive copyright/license boilerplate	10 years ago
debugger	Remove excessive copyright/license boilerplate	10 years ago
disabled	Remove excessive copyright/license boilerplate	10 years ago
fixtures	Remove excessive copyright/license boilerplate	10 years ago
gc	test: update our branched weakref to v8 3.24	11 years ago
internet	Remove excessive copyright/license boilerplate	10 years ago
message	test: fix message tests regression	10 years ago
parallel	test: use assert.throw to test exceptions	10 years ago
pummel	Remove excessive copyright/license boilerplate	10 years ago
sequential	Remove excessive copyright/license boilerplate	10 years ago
testpy	test: fix `make test-addons` target	10 years ago
timers	test: make test runner multi-arch/mode compatible	11 years ago
common.js	test: check for multi-localhost support	10 years ago