lukechilds/node - node - Gitea: Git with a cup of tea

History

Julien Gilli edfc8cde04 deps: backport 1ee712a from V8 upstream Backport 1ee712ab8687e5f4dec93d45da068d37d28feb8b from V8 upstream. Original commit message: Add SetAbortOnUncaughtExceptionCallback API The --abort-on-uncaught-exception command line switch makes Isolate::Throw abort if the error being thrown cannot be caught by a try/catch block. Embedders may want to use other mechanisms than try/catch blocks to handle uncaught exceptions. For instance, Node.js has "domain" objects that have error handlers that can handle uncaught exception like following: var d = domain.create(); d.on('error', function onError(err) { console.log('Handling error'); }); d.run(function() { throw new Error("boom"); }); These error handlers are called by isolates' message listeners. If --abort-on-uncaught-exception is not used, the isolate's message listener will be called, which will in turn call the domain's error handler. The process will output 'Handling error' and will exit successfully (not due to an uncaught exception). This is the behavior that Node.js users expect. However, if --abort-on-uncaught-exception is used and when throwing an error within a domain that has an error handler, the process will abort and the domain's error handler will not be called. This is not the behavior that Node.js users expect. Having a SetAbortOnUncaughtExceptionCallback API allows embedders to determine when it's not appropriate to abort and instead handle the exception via the isolate's message listener. In the example above, Node.js would set a custom callback with SetAbortOnUncaughtExceptionCallback that would be implemented as following (the sample code has been simplified to remove what's not relevant to this change): bool ShouldAbortOnUncaughtException(Isolate* isolate) { return !IsDomainActive(); } Now when --abort-on-uncaught-exception is used, Isolate::Throw would call that callback and determine that it should not abort if a domain with an error handler is active. Instead, the isolate's message listener would be called and the error would be handled by the domain's error handler. I believe this can also be useful for other embedders. BUG= R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1375933003 Cr-Commit-Position: refs/heads/master@{#31111} Ref: #3036 Ref: https://github.com/nodejs/node/pull/3481 PR-URL: https://github.com/nodejs/node/pull/4106 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com> Reviewed-By: rvagg - Rod Vagg <rod@vagg.org>		9 years ago
..
benchmarks	deps: upgrade V8 to 4.6.85.23	9 years ago
cctest	deps: backport 1ee712a from V8 upstream	9 years ago
intl	deps: upgrade V8 to 4.7.80.24	9 years ago
js-perf-test	deps: upgrade V8 to 4.7.80.24	9 years ago
memory	deps: update v8 to 4.4.63.9	10 years ago
message	deps: upgrade V8 to 4.7.80.24	9 years ago
mjsunit	deps: upgrade V8 to 4.7.80.24	9 years ago
mozilla	deps: upgrade V8 to 4.7.80.24	9 years ago
preparser	deps: upgrade V8 to 4.6.85.23	9 years ago
promises-aplus	deps: upgrade V8 to 4.6.85.23	9 years ago
simdjs	deps: upgrade V8 to 4.7.80.24	9 years ago
test262	deps: upgrade V8 to 4.7.80.24	9 years ago
unittests	deps: upgrade V8 to 4.7.80.24	9 years ago
webkit	deps: upgrade V8 to 4.7.80.24	9 years ago