lukechilds/node - node - Gitea: Git with a cup of tea

History

Gireesh Punathil 13e1131406 test: address timing issues in simple http tests simple tests test-http-request-end.js, test-http-default-encoding.js hangs in AIX. The root cause for both the failures is related to the timing with which packets are sent between the client and server. On the client side, one factor that affects the timing is Nagle's algorithm. With Nagle enabled there may be a delay between two packets as the stack may wait until either: a. An acknowledgement for the first packet is received, or b. 200 ms elapses. before sending the second packet. Similarly at the server side 2 sequential packages can be delivered to the application either together or separatly. On AIX we see that they are delivered separately to the server, while on Linux delivered together. If we change the timing, for example disabling Nagle on AIX we see the 2 packets delivered together and the tests pass. In the test case simple/test-http-request-end.js, the client request handler of the server receives and stores the data in a data callback, closes the server in a request end callback, and writes to the client and ends the response, in-line with the request receipt. An HTTP parser module parses the incoming message, and invokes callback routines which are registered for HTTP events (such as header, body, end etc.) Because the termination sequence arrive in a separate packet, there is a delay in parsing that message and identify that the client request ended (and thereby invoke the request end call backhandler). Due to this delay, the response close happens first, which in-turn destroys the server socket leading to the fd and watcher removal from the uv loop abandoning further events on this connection, and end call back never being called, causing the reported hang. simple/test-http-default-encoding.js suffers from the same problem. Also, remove the timer logic from the test case. Test harness anyways contain a timer which controls the individual tests so remove such controls from the test case, as suggested by @tjfontaine Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: https://github.com/joyent/node/pull/9432		10 years ago
..
addons	smalloc: extend user API	10 years ago
debugger	debugger: assign Environment to DebugContext too	11 years ago
disabled	deps: re-implement debugger-agent	11 years ago
external/ssl-options	test: fix ssl/tls options matrix test	10 years ago
fixtures	test: fix debug-signal-cluster after da update	11 years ago
gc	test: update our branched weakref to v8 3.24	11 years ago
internet	Merge remote-tracking branch 'upstream/v0.10' into merge-0-10-into-0-12	10 years ago
message	Merge branch 'v0.10'	11 years ago
pummel	mdb_v8: add tests for ::findjsobjects -k KIND	10 years ago
simple	test: address timing issues in simple http tests	10 years ago
testpy	test: Env variable to specify directory for pipes	10 years ago
timers	timers: backport f8193ab	11 years ago
common.js	test: Env variable to specify directory for pipes	10 years ago