lukechilds/node - node - Gitea: Git with a cup of tea

History

Myles Borins 28e9a022df test: wrap assert.fail when passed to callback Currently there are many instances where assert.fail is directly passed to a callback for error handling. Unfortunately this will swallow the error as it is the third argument of assert.fail that sets the message not the first. This commit adds a new function to test/common.js that simply wraps assert.fail and calls it with the provided message. Tip of the hat to @trott for pointing me in the direction of this. PR-URL: https://github.com/nodejs/node/pull/3453 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>		9 years ago
..
abort	src: honor --abort_on_uncaught_exception flag	9 years ago
addons	test: add node::MakeCallback() test coverage	9 years ago
cctest	deps: check in gtest, add util unit test	10 years ago
debugger	test: load common.js in all tests	9 years ago
disabled	test: replace deprecated util.debug() calls	9 years ago
fixtures	util: Remove p, has been deprecated for years	9 years ago
gc	src: replace usage of v8::Handle with v8::Local	9 years ago
internet	test: skip test-dns-ipv6.js if ipv6 is unavailable	9 years ago
message	test: remove flaky status from eval_messages test	9 years ago
parallel	test: wrap assert.fail when passed to callback	9 years ago
pummel	test: wrap assert.fail when passed to callback	9 years ago
sequential	test: wrap assert.fail when passed to callback	9 years ago
testpy	test: fix default value for additional param	9 years ago
timers	test: enable linting for tests	10 years ago
.eslintrc	test: make common.js mandatory via linting rule	9 years ago
common.js	test: wrap assert.fail when passed to callback	9 years ago