mirror of https://github.com/lukechilds/node.git
You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
227 lines
7.6 KiB
227 lines
7.6 KiB
/**
|
|
* @fileoverview Internal rule to prevent missing or invalid meta property in core rules.
|
|
* @author Vitor Balocco
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Helpers
|
|
//------------------------------------------------------------------------------
|
|
|
|
/**
|
|
* Gets the property of the Object node passed in that has the name specified.
|
|
*
|
|
* @param {string} property Name of the property to return.
|
|
* @param {ASTNode} node The ObjectExpression node.
|
|
* @returns {ASTNode} The Property node or null if not found.
|
|
*/
|
|
function getPropertyFromObject(property, node) {
|
|
const properties = node.properties;
|
|
|
|
for (let i = 0; i < properties.length; i++) {
|
|
if (properties[i].key.name === property) {
|
|
return properties[i];
|
|
}
|
|
}
|
|
|
|
return null;
|
|
}
|
|
|
|
/**
|
|
* Extracts the `meta` property from the ObjectExpression that all rules export.
|
|
*
|
|
* @param {ASTNode} exportsNode ObjectExpression node that the rule exports.
|
|
* @returns {ASTNode} The `meta` Property node or null if not found.
|
|
*/
|
|
function getMetaPropertyFromExportsNode(exportsNode) {
|
|
return getPropertyFromObject("meta", exportsNode);
|
|
}
|
|
|
|
/**
|
|
* Whether this `meta` ObjectExpression has a `docs` property defined or not.
|
|
*
|
|
* @param {ASTNode} metaPropertyNode The `meta` ObjectExpression for this rule.
|
|
* @returns {boolean} `true` if a `docs` property exists.
|
|
*/
|
|
function hasMetaDocs(metaPropertyNode) {
|
|
return Boolean(getPropertyFromObject("docs", metaPropertyNode.value));
|
|
}
|
|
|
|
/**
|
|
* Whether this `meta` ObjectExpression has a `docs.description` property defined or not.
|
|
*
|
|
* @param {ASTNode} metaPropertyNode The `meta` ObjectExpression for this rule.
|
|
* @returns {boolean} `true` if a `docs.description` property exists.
|
|
*/
|
|
function hasMetaDocsDescription(metaPropertyNode) {
|
|
const metaDocs = getPropertyFromObject("docs", metaPropertyNode.value);
|
|
|
|
return metaDocs && getPropertyFromObject("description", metaDocs.value);
|
|
}
|
|
|
|
/**
|
|
* Whether this `meta` ObjectExpression has a `docs.category` property defined or not.
|
|
*
|
|
* @param {ASTNode} metaPropertyNode The `meta` ObjectExpression for this rule.
|
|
* @returns {boolean} `true` if a `docs.category` property exists.
|
|
*/
|
|
function hasMetaDocsCategory(metaPropertyNode) {
|
|
const metaDocs = getPropertyFromObject("docs", metaPropertyNode.value);
|
|
|
|
return metaDocs && getPropertyFromObject("category", metaDocs.value);
|
|
}
|
|
|
|
/**
|
|
* Whether this `meta` ObjectExpression has a `docs.recommended` property defined or not.
|
|
*
|
|
* @param {ASTNode} metaPropertyNode The `meta` ObjectExpression for this rule.
|
|
* @returns {boolean} `true` if a `docs.recommended` property exists.
|
|
*/
|
|
function hasMetaDocsRecommended(metaPropertyNode) {
|
|
const metaDocs = getPropertyFromObject("docs", metaPropertyNode.value);
|
|
|
|
return metaDocs && getPropertyFromObject("recommended", metaDocs.value);
|
|
}
|
|
|
|
/**
|
|
* Whether this `meta` ObjectExpression has a `schema` property defined or not.
|
|
*
|
|
* @param {ASTNode} metaPropertyNode The `meta` ObjectExpression for this rule.
|
|
* @returns {boolean} `true` if a `schema` property exists.
|
|
*/
|
|
function hasMetaSchema(metaPropertyNode) {
|
|
return getPropertyFromObject("schema", metaPropertyNode.value);
|
|
}
|
|
|
|
/**
|
|
* Whether this `meta` ObjectExpression has a `fixable` property defined or not.
|
|
*
|
|
* @param {ASTNode} metaPropertyNode The `meta` ObjectExpression for this rule.
|
|
* @returns {boolean} `true` if a `fixable` property exists.
|
|
*/
|
|
function hasMetaFixable(metaPropertyNode) {
|
|
return getPropertyFromObject("fixable", metaPropertyNode.value);
|
|
}
|
|
|
|
/**
|
|
* Checks the validity of the meta definition of this rule and reports any errors found.
|
|
*
|
|
* @param {RuleContext} context The ESLint rule context.
|
|
* @param {ASTNode} exportsNode ObjectExpression node that the rule exports.
|
|
* @param {boolean} ruleIsFixable whether the rule is fixable or not.
|
|
* @returns {void}
|
|
*/
|
|
function checkMetaValidity(context, exportsNode, ruleIsFixable) {
|
|
const metaProperty = getMetaPropertyFromExportsNode(exportsNode);
|
|
|
|
if (!metaProperty) {
|
|
context.report(exportsNode, "Rule is missing a meta property.");
|
|
return;
|
|
}
|
|
|
|
if (!hasMetaDocs(metaProperty)) {
|
|
context.report(metaProperty, "Rule is missing a meta.docs property.");
|
|
return;
|
|
}
|
|
|
|
if (!hasMetaDocsDescription(metaProperty)) {
|
|
context.report(metaProperty, "Rule is missing a meta.docs.description property.");
|
|
return;
|
|
}
|
|
|
|
if (!hasMetaDocsCategory(metaProperty)) {
|
|
context.report(metaProperty, "Rule is missing a meta.docs.category property.");
|
|
return;
|
|
}
|
|
|
|
if (!hasMetaDocsRecommended(metaProperty)) {
|
|
context.report(metaProperty, "Rule is missing a meta.docs.recommended property.");
|
|
return;
|
|
}
|
|
|
|
if (!hasMetaSchema(metaProperty)) {
|
|
context.report(metaProperty, "Rule is missing a meta.schema property.");
|
|
return;
|
|
}
|
|
|
|
if (ruleIsFixable && !hasMetaFixable(metaProperty)) {
|
|
context.report(metaProperty, "Rule is fixable, but is missing a meta.fixable property.");
|
|
return;
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Whether this node is the correct format for a rule definition or not.
|
|
*
|
|
* @param {ASTNode} node node that the rule exports.
|
|
* @returns {boolean} `true` if the exported node is the correct format for a rule definition
|
|
*/
|
|
function isCorrectExportsFormat(node) {
|
|
return node.type === "ObjectExpression";
|
|
}
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
module.exports = {
|
|
meta: {
|
|
docs: {
|
|
description: "enforce correct use of `meta` property in core rules",
|
|
category: "Internal",
|
|
recommended: false
|
|
},
|
|
|
|
schema: []
|
|
},
|
|
|
|
create(context) {
|
|
let exportsNode;
|
|
let ruleIsFixable = false;
|
|
|
|
return {
|
|
AssignmentExpression(node) {
|
|
if (node.left &&
|
|
node.right &&
|
|
node.left.type === "MemberExpression" &&
|
|
node.left.object.name === "module" &&
|
|
node.left.property.name === "exports") {
|
|
|
|
exportsNode = node.right;
|
|
}
|
|
},
|
|
|
|
CallExpression(node) {
|
|
|
|
// If the rule has a call for `context.report` and a property `fix`
|
|
// is being passed in, then we consider that the rule is fixable.
|
|
//
|
|
// Note that we only look for context.report() calls in the new
|
|
// style (with single MessageDescriptor argument), because only
|
|
// calls in the new style can specify a fix.
|
|
if (node.callee.type === "MemberExpression" &&
|
|
node.callee.object.type === "Identifier" &&
|
|
node.callee.object.name === "context" &&
|
|
node.callee.property.type === "Identifier" &&
|
|
node.callee.property.name === "report" &&
|
|
node.arguments.length === 1 &&
|
|
node.arguments[0].type === "ObjectExpression") {
|
|
|
|
if (getPropertyFromObject("fix", node.arguments[0])) {
|
|
ruleIsFixable = true;
|
|
}
|
|
}
|
|
},
|
|
|
|
"Program:exit"() {
|
|
if (!isCorrectExportsFormat(exportsNode)) {
|
|
context.report(exportsNode, "Rule does not export an Object. Make sure the rule follows the new rule format.");
|
|
return;
|
|
}
|
|
|
|
checkMetaValidity(context, exportsNode, ruleIsFixable);
|
|
}
|
|
};
|
|
}
|
|
};
|
|
|