lukechilds/node - node - Gitea: Git with a cup of tea

History

Ben Noordhuis 50177fb13c benchmark: stop v8 benchmark clobbering RegExp deps/v8/benchmarks/regexp.js clobbers the RegExp global, breaking util.format() and console.log(). Unclobber it to keep the other benchmarks working. Fixes the following error when running benchmark/misc/v8-bench.js: $ out/Release/iojs benchmark/misc/v8-bench.js util.js:84 if (new RegExp('\\b' + set + '\\b', 'i').test(debugEnviron)) { ^ TypeError: object is not a function at Object.exports.debuglog (util.js:84:9) at timers.js:12:29 at NativeModule.compile (node.js:800:5) at NativeModule.require (node.js:769:18) at net.js:5:14 at NativeModule.compile (node.js:800:5) at NativeModule.require (node.js:769:18) at tty.js:4:11 at NativeModule.compile (node.js:800:5) at Function.NativeModule.require (node.js:769:18) This could alternatively be addressed by caching the RegExp global in lib/util.js. That's not a bad approach and I considered it but doing it for just RegExp and not other globals would be half-baked. Maybe the more thorough approach where we cache all globals at start-up is something for a follow-up pull request. Fixes: https://github.com/iojs/io.js/pull/475 PR-URL: https://github.com/iojs/io.js/pull/489 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>		10 years ago
..
function_call	benchmark: update misc to new v8 API	12 years ago
child-process-read.js	bench: add child process read perf benchmark	12 years ago
domain-fn-args.js	domain: forward args to .run(fn)	10 years ago
module-loader.js	Remove excessive copyright/license boilerplate	10 years ago
next-tick-breadth.js	bench: move next-tick to misc/next-tick-breadth	12 years ago
next-tick-depth.js	Remove excessive copyright/license boilerplate	10 years ago
spawn-echo.js	bench: Move process_loop to misc/spawn-echo	12 years ago
startup.js	bench: Simplify duration arguments to benchmarks	12 years ago
string-creation.js	bench: Consistency in benchmark filenames	12 years ago
timers.js	bench: Move timers to misc/timers	12 years ago
url.js	bench: misc/url	12 years ago
v8-bench.js	benchmark: stop v8 benchmark clobbering RegExp	10 years ago