lukechilds/node - node - Gitea: Git with a cup of tea

History

Gabriel Schulhof d5b397c9b6 n-api: Implement stricter wrapping Use a stronger criterion to identify objects in the prototype chain that store pointers to native data that were added by previous calls to `napi_wrap()`. Whereas the old criterion for identifying `napi_wrap()`-injected prototype chain objects was to consider an object with an internal field count of 1 to be such an object, the new criterion is to consider an object with an internal field count of 2 such that the second field holds a `v8::External` which itself contains a pointer to a global static string unique to N-API to be a `napi_wrap()`-injected prototype chain object. This greatly reduces the possibility of returning a pointer that was not previously added with `napi_wrap()`, and it allows us to recognize that an object has already undergone `napi_wrap()` and we can thus prevent a chain of wrappers only the first of which is accessible from appearing in the prototype chain, as would be the result of multiple calls to `napi_wrap()` using the same object. PR-URL: https://github.com/nodejs/node/pull/13872 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com>		8 years ago
..
api	n-api: Implement stricter wrapping	8 years ago
api_assets	doc: reduce font size on smaller screens	8 years ago
changelogs	2017-07-11, Version 8.1.4 (Current)	8 years ago
guides	doc: fix indentation issues in sample code	8 years ago
.eslintrc.yaml	tools: eslint - use `error` and `off`	8 years ago
STYLE_GUIDE.md	doc: update backporting guide	8 years ago
full-white-stripe.jpg	build: update Node.js logo on Win installer	9 years ago
node.1	src: document --abort-on-uncaught-exception	8 years ago
onboarding-extras.md	doc: add @nodejs/documentation to CC table	8 years ago
onboarding.md	doc: small makeover for onboarding.md	8 years ago
osx_installer_logo.png	build: update Node.js logo on OSX installer	9 years ago
releases.md	doc: mention rebasing of v?.x-staging post release	8 years ago
template.html	tools,doc: add Google Analytics tracking.	8 years ago
thin-white-stripe.jpg	build: update Node.js logo on Win installer	9 years ago