mirror of https://github.com/lukechilds/node.git
You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
305 lines
10 KiB
305 lines
10 KiB
/**
|
|
* @fileoverview Rule to flag declared but unused variables
|
|
* @author Ilya Volodin
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Requirements
|
|
//------------------------------------------------------------------------------
|
|
|
|
var lodash = require("lodash");
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
module.exports = function(context) {
|
|
|
|
var MESSAGE = "'{{name}}' is defined but never used";
|
|
|
|
var config = {
|
|
vars: "all",
|
|
args: "after-used"
|
|
};
|
|
|
|
var firstOption = context.options[0];
|
|
|
|
if (firstOption) {
|
|
if (typeof firstOption === "string") {
|
|
config.vars = firstOption;
|
|
} else {
|
|
config.vars = firstOption.vars || config.vars;
|
|
config.args = firstOption.args || config.args;
|
|
|
|
if (firstOption.varsIgnorePattern) {
|
|
config.varsIgnorePattern = new RegExp(firstOption.varsIgnorePattern);
|
|
}
|
|
|
|
if (firstOption.argsIgnorePattern) {
|
|
config.argsIgnorePattern = new RegExp(firstOption.argsIgnorePattern);
|
|
}
|
|
}
|
|
}
|
|
|
|
//--------------------------------------------------------------------------
|
|
// Helpers
|
|
//--------------------------------------------------------------------------
|
|
|
|
/**
|
|
* Determines if a given variable is being exported from a module.
|
|
* @param {Variable} variable - EScope variable object.
|
|
* @returns {boolean} True if the variable is exported, false if not.
|
|
* @private
|
|
*/
|
|
function isExported(variable) {
|
|
|
|
var definition = variable.defs[0];
|
|
|
|
if (definition) {
|
|
|
|
var node = definition.node;
|
|
if (node.type === "VariableDeclarator") {
|
|
node = node.parent;
|
|
} else if (definition.type === "Parameter") {
|
|
return false;
|
|
}
|
|
|
|
return node.parent.type.indexOf("Export") === 0;
|
|
} else {
|
|
return false;
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Determines if a reference is a read operation.
|
|
* @param {Reference} ref - An escope Reference
|
|
* @returns {Boolean} whether the given reference represents a read operation
|
|
* @private
|
|
*/
|
|
function isReadRef(ref) {
|
|
return ref.isRead();
|
|
}
|
|
|
|
/**
|
|
* Determine if an identifier is referencing an enclosing function name.
|
|
* @param {Reference} ref - The reference to check.
|
|
* @param {ASTNode[]} nodes - The candidate function nodes.
|
|
* @returns {boolean} True if it's a self-reference, false if not.
|
|
* @private
|
|
*/
|
|
function isSelfReference(ref, nodes) {
|
|
var scope = ref.from;
|
|
|
|
while (scope) {
|
|
if (nodes.indexOf(scope.block) >= 0) {
|
|
return true;
|
|
}
|
|
|
|
scope = scope.upper;
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
/**
|
|
* Determines if the variable is used.
|
|
* @param {Variable} variable - The variable to check.
|
|
* @param {Reference[]} references - The variable references to check.
|
|
* @returns {boolean} True if the variable is used
|
|
*/
|
|
function isUsedVariable(variable) {
|
|
var functionNodes = variable.defs.filter(function(def) {
|
|
return def.type === "FunctionName";
|
|
}).map(function(def) {
|
|
return def.node;
|
|
}),
|
|
isFunctionDefinition = functionNodes.length > 0;
|
|
|
|
return variable.references.some(function(ref) {
|
|
return isReadRef(ref) && !(isFunctionDefinition && isSelfReference(ref, functionNodes));
|
|
});
|
|
}
|
|
|
|
/**
|
|
* Gets an array of variables without read references.
|
|
* @param {Scope} scope - an escope Scope object.
|
|
* @param {Variable[]} unusedVars - an array that saving result.
|
|
* @returns {Variable[]} unused variables of the scope and descendant scopes.
|
|
* @private
|
|
*/
|
|
function collectUnusedVariables(scope, unusedVars) {
|
|
var variables = scope.variables;
|
|
var childScopes = scope.childScopes;
|
|
var i, l;
|
|
|
|
if (scope.type !== "TDZ" && (scope.type !== "global" || config.vars === "all")) {
|
|
for (i = 0, l = variables.length; i < l; ++i) {
|
|
var variable = variables[i];
|
|
|
|
// skip a variable of class itself name in the class scope
|
|
if (scope.type === "class" && scope.block.id === variable.identifiers[0]) {
|
|
continue;
|
|
}
|
|
// skip function expression names and variables marked with markVariableAsUsed()
|
|
if (scope.functionExpressionScope || variable.eslintUsed) {
|
|
continue;
|
|
}
|
|
// skip implicit "arguments" variable
|
|
if (scope.type === "function" && variable.name === "arguments" && variable.identifiers.length === 0) {
|
|
continue;
|
|
}
|
|
|
|
// explicit global variables don't have definitions.
|
|
var def = variable.defs[0];
|
|
if (def) {
|
|
var type = def.type;
|
|
|
|
// skip catch variables
|
|
if (type === "CatchClause") {
|
|
continue;
|
|
}
|
|
|
|
if (type === "Parameter") {
|
|
// skip any setter argument
|
|
if (def.node.parent.type === "Property" && def.node.parent.kind === "set") {
|
|
continue;
|
|
}
|
|
|
|
// if "args" option is "none", skip any parameter
|
|
if (config.args === "none") {
|
|
continue;
|
|
}
|
|
|
|
// skip ignored parameters
|
|
if (config.argsIgnorePattern && config.argsIgnorePattern.test(def.name.name)) {
|
|
continue;
|
|
}
|
|
|
|
// if "args" option is "after-used", skip all but the last parameter
|
|
if (config.args === "after-used" && def.index < def.node.params.length - 1) {
|
|
continue;
|
|
}
|
|
} else {
|
|
// skip ignored variables
|
|
if (config.varsIgnorePattern && config.varsIgnorePattern.test(def.name.name)) {
|
|
continue;
|
|
}
|
|
}
|
|
}
|
|
|
|
if (!isUsedVariable(variable) && !isExported(variable)) {
|
|
unusedVars.push(variable);
|
|
}
|
|
}
|
|
}
|
|
|
|
for (i = 0, l = childScopes.length; i < l; ++i) {
|
|
collectUnusedVariables(childScopes[i], unusedVars);
|
|
}
|
|
|
|
return unusedVars;
|
|
}
|
|
|
|
/**
|
|
* Gets the index of a given variable name in a given comment.
|
|
* @param {escope.Variable} variable - A variable to get.
|
|
* @param {ASTNode} comment - A comment node which includes the variable name.
|
|
* @returns {number} The index of the variable name's location.
|
|
*/
|
|
function getColumnInComment(variable, comment) {
|
|
var namePattern = new RegExp("[\\s,]" + lodash.escapeRegExp(variable.name) + "(?:$|[\\s,:])", "g");
|
|
|
|
// To ignore the first text "global".
|
|
namePattern.lastIndex = comment.value.indexOf("global") + 6;
|
|
|
|
// Search a given variable name.
|
|
var match = namePattern.exec(comment.value);
|
|
return match ? match.index + 1 : 0;
|
|
}
|
|
|
|
/**
|
|
* Creates the correct location of a given variables.
|
|
* The location is at its name string in a `/*global` comment.
|
|
*
|
|
* @param {escope.Variable} variable - A variable to get its location.
|
|
* @returns {{line: number, column: number}} The location object for the variable.
|
|
*/
|
|
function getLocation(variable) {
|
|
var comment = variable.eslintExplicitGlobalComment;
|
|
var baseLoc = comment.loc.start;
|
|
var column = getColumnInComment(variable, comment);
|
|
var prefix = comment.value.slice(0, column);
|
|
var lineInComment = (prefix.match(/\n/g) || []).length;
|
|
|
|
if (lineInComment > 0) {
|
|
column -= 1 + prefix.lastIndexOf("\n");
|
|
} else {
|
|
// 2 is for `/*`
|
|
column += baseLoc.column + 2;
|
|
}
|
|
|
|
return {
|
|
line: baseLoc.line + lineInComment,
|
|
column: column
|
|
};
|
|
}
|
|
|
|
//--------------------------------------------------------------------------
|
|
// Public
|
|
//--------------------------------------------------------------------------
|
|
|
|
return {
|
|
"Program:exit": function(programNode) {
|
|
var unusedVars = collectUnusedVariables(context.getScope(), []);
|
|
|
|
for (var i = 0, l = unusedVars.length; i < l; ++i) {
|
|
var unusedVar = unusedVars[i];
|
|
|
|
if (unusedVar.eslintExplicitGlobal) {
|
|
context.report({
|
|
node: programNode,
|
|
loc: getLocation(unusedVar),
|
|
message: MESSAGE,
|
|
data: unusedVar
|
|
});
|
|
} else if (unusedVar.defs.length > 0) {
|
|
context.report({
|
|
node: unusedVar.identifiers[0],
|
|
message: MESSAGE,
|
|
data: unusedVar
|
|
});
|
|
}
|
|
}
|
|
}
|
|
};
|
|
|
|
};
|
|
|
|
module.exports.schema = [
|
|
{
|
|
"oneOf": [
|
|
{
|
|
"enum": ["all", "local"]
|
|
},
|
|
{
|
|
"type": "object",
|
|
"properties": {
|
|
"vars": {
|
|
"enum": ["all", "local"]
|
|
},
|
|
"varsIgnorePattern": {
|
|
"type": "string"
|
|
},
|
|
"args": {
|
|
"enum": ["all", "after-used", "none"]
|
|
},
|
|
"argsIgnorePattern": {
|
|
"type": "string"
|
|
}
|
|
}
|
|
}
|
|
]
|
|
}
|
|
];
|
|
|