mirror of https://github.com/lukechilds/node.git
You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
72 lines
2.0 KiB
72 lines
2.0 KiB
/**
|
|
* @fileoverview Rule to flag use of an empty block statement
|
|
* @author Nicholas C. Zakas
|
|
*/
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
var FUNCTION_TYPE = /^(?:ArrowFunctionExpression|Function(?:Declaration|Expression))$/;
|
|
|
|
module.exports = {
|
|
meta: {
|
|
docs: {
|
|
description: "disallow empty block statements",
|
|
category: "Possible Errors",
|
|
recommended: true
|
|
},
|
|
|
|
schema: [
|
|
{
|
|
type: "object",
|
|
properties: {
|
|
allowEmptyCatch: {
|
|
type: "boolean"
|
|
}
|
|
},
|
|
additionalProperties: false
|
|
}
|
|
]
|
|
},
|
|
|
|
create: function(context) {
|
|
var options = context.options[0] || {},
|
|
allowEmptyCatch = options.allowEmptyCatch || false;
|
|
|
|
return {
|
|
BlockStatement: function(node) {
|
|
|
|
// if the body is not empty, we can just return immediately
|
|
if (node.body.length !== 0) {
|
|
return;
|
|
}
|
|
|
|
// a function is generally allowed to be empty
|
|
if (FUNCTION_TYPE.test(node.parent.type)) {
|
|
return;
|
|
}
|
|
|
|
if (allowEmptyCatch && node.parent.type === "CatchClause") {
|
|
return;
|
|
}
|
|
|
|
// any other block is only allowed to be empty, if it contains a comment
|
|
if (context.getComments(node).trailing.length > 0) {
|
|
return;
|
|
}
|
|
|
|
context.report(node, "Empty block statement.");
|
|
},
|
|
|
|
SwitchStatement: function(node) {
|
|
|
|
if (typeof node.cases === "undefined" || node.cases.length === 0) {
|
|
context.report(node, "Empty switch statement.");
|
|
}
|
|
}
|
|
};
|
|
|
|
}
|
|
};
|
|
|