lukechilds/node - node - Gitea: Git with a cup of tea

History

Vse Mozhet Byt 76340e3f10 test: fix RegExp nits * Remove needless RegExp flag In fixed case, `/g` flag is needless in the boolean context. * Remove needless RegExp capturing Use non-capturing grouping or remove capturing completely when: * capturing is useless per se, e.g. in test() check; * captured groups are not used afterward at all; * some of the later captured groups are not used afterward. * Use test, not match/exec in boolean context match() and exec() return a complicated object, unneeded in a boolean context. * Do not needlessly repeat RegExp creation This commit takes RegExp creation out of cycles and other repetitions. As long as the RegExp does not use /g flag and match indices, we are safe here. In tests, this fix hardly gives a significant performance gain, but it increases clarity and maintainability, reassuring some RegExps to be identical. RegExp in functions are not taken out of their functions: while these functions are called many times and their RegExps are recreated with each call, the performance gain in test cases does not seem to be worth decreasing function self-dependency. PR-URL: https://github.com/nodejs/node/pull/13770 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>		8 years ago
..
global-function.js	inspector: Allows reentry when paused	8 years ago
inspector-helper.js	test: fix RegExp nits	8 years ago
inspector.status	test: fix test-inspector-port-zero-cluster	8 years ago
test-bindings.js	test: skip test-bindings if inspector is disabled	8 years ago
test-inspector-break-when-eval.js	inspector: Allows reentry when paused	8 years ago
test-inspector-debug-brk.js	test: rearrange inspector headers into convention	8 years ago
test-inspector-exception.js	inspector: fix crash on exception	8 years ago
test-inspector-ip-detection.js	test: rearrange inspector headers into convention	8 years ago
test-inspector-port-cluster.js	inspector,cluster: fix inspect port assignment	8 years ago
test-inspector-port-zero-cluster.js	test: fix test-inspector-port-zero-cluster	8 years ago
test-inspector-port-zero.js	src: check whether inspector is doing io	8 years ago
test-inspector-stops-no-file.js	test: rearrange inspector headers into convention	8 years ago
test-inspector.js	test: fix RegExp nits	8 years ago
test-not-blocked-on-idle.js	test: make tests pass when configured without-ssl	8 years ago
test-off-no-session.js	inspector: fix process._debugEnd() for inspector	8 years ago
test-off-with-session-then-on.js	inspector: fix process._debugEnd() for inspector	8 years ago
testcfg.py	inspector: introduce a smoke test	8 years ago