lukechilds/node - node - Gitea: Git with a cup of tea

History

Joseph Gentle 6481c93aef assert: add support for Map and Set in deepEqual assert.deepEqual and assert.deepStrictEqual currently return true for any pair of Maps and Sets regardless of content. This patch adds support in deepEqual and deepStrictEqual to verify the contents of Maps and Sets. Deeo equivalence checking is currently an O(n^2) operation, and worse, it gets slower exponentially if maps and sets were nested. Note that this change breaks compatibility with previous versions of deepEqual and deepStrictEqual if consumers were depending on all maps and sets to be seen as equivalent. The old behaviour was never documented, but nevertheless there are certainly some tests out there which depend on it. Support has stalled because the assert API was frozen, but was recently unfrozen in CTC#63. --- Later squashed in: This change updates the checks for deep equality checking on Map and Set to check all set values / all map keys to see if any of them match the expected result. This change is much slower, but based on the conversation in the pull request its probably the right approach. Fixes: https://github.com/nodejs/node/issues/2309 Refs: https://github.com/substack/tape/issues/342 Refs: https://github.com/nodejs/node/pull/2315 Refs: https://github.com/nodejs/CTC/issues/63 PR-URL: https://github.com/nodejs/node/pull/12142 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>		8 years ago
..
api	assert: add support for Map and Set in deepEqual	8 years ago
api_assets	doc: reduce font size on smaller screens	8 years ago
changelogs	2017-03-28, Version 7.8.0 (Current)	8 years ago
guides	doc: edit the benchmark guide	8 years ago
STYLE_GUIDE.md	doc: fix typo in STYLE_GUIDE.md	8 years ago
full-white-stripe.jpg	build: update Node.js logo on Win installer	9 years ago
node.1	tty: remove NODE_TTY_UNSAFE_ASYNC	8 years ago
onboarding-extras.md	doc: add not-an-aardvark as ESLint contact	8 years ago
onboarding.md	doc: add personal pronouns option	8 years ago
osx_installer_logo.png	build: update Node.js logo on OSX installer	9 years ago
releases.md	doc: add commit formats for release blog posts	9 years ago
template.html	tools,doc: add Google Analytics tracking.	8 years ago
thin-white-stripe.jpg	build: update Node.js logo on Win installer	9 years ago