lukechilds/node - node - Gitea: Git with a cup of tea

Tree: 73416b46e4

Rich Trott 688e5ed6fd test: remove common.noop This change removes `common.noop` from the Node.js internal testing common module. Over the last few weeks, I've grown to dislike the `common.noop` abstraction. First, new (and experienced) contributors are unaware of it and so it results in a large number of low-value nits on PRs. It also increases the number of things newcomers and infrequent contributors have to be aware of to be effective on the project. Second, it is confusing. Is it a singleton/property or a getter? Which should be expected? This can lead to subtle and hard-to-find bugs. (To my knowledge, none have landed on master. But I also think it's only a matter of time.) Third, the abstraction is low-value in my opinion. What does it really get us? A case could me made that it is without value at all. Lastly, and this is minor, but the abstraction is wordier than not using the abstraction. `common.noop` doesn't save anything over `() => {}`. So, I propose removing it. PR-URL: https://github.com/nodejs/node/pull/12822 Backport-PR-URL: https://github.com/nodejs/node/pull/14174 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>		8 years ago
..
helper-debugger-repl.js	test: fix RegExp nits	8 years ago
test-debug-break-on-uncaught.js	test: increase timeout in break-on-uncaught	8 years ago
test-debugger-client.js	test: remove common.noop	7 years ago
test-debugger-remote.js	test: add common.mustNotCall()	8 years ago
test-debugger-repl-break-in-module.js	test: use eslint to fix var->const/let	8 years ago
test-debugger-repl-restart.js	test: use eslint to fix var->const/let	8 years ago
test-debugger-repl-term.js	test: use eslint to fix var->const/let	8 years ago
test-debugger-repl-utf8.js	test: reduce string concatenations	8 years ago
test-debugger-repl.js	test: use eslint to fix var->const/let	8 years ago
testcfg.py	test: move debugger repl into own section	11 years ago