lukechilds/node - node - Gitea: Git with a cup of tea

History

isaacs b0de1e4a41 stream: Fix unshift() race conditions Fix #5272 The consumption of a readable stream is a dance with 3 partners. 1. The specific stream Author (A) 2. The Stream Base class (B), and 3. The Consumer of the stream (C) When B calls the _read() method that A implements, it sets a 'reading' flag, so that parallel calls to _read() can be avoided. When A calls stream.push(), B knows that it's safe to start calling _read() again. If the consumer C is some kind of parser that wants in some cases to pass the source stream off to some other party, but not before "putting back" some bit of previously consumed data (as in the case of Node's websocket http upgrade implementation). So, stream.unshift() will generally never be called by A, but only called by C. Prior to this patch, stream.unshift() also unset the state.reading flag, meaning that C could indicate the end of a read, and B would dutifully fire off another _read() call to A. This is inappropriate. In the case of fs streams, and other variably-laggy streams that don't tolerate overlapped _read() calls, this causes big problems. Also, calling stream.shift() after the 'end' event did not raise any kind of error, but would cause very strange behavior indeed. Calling it after the EOF chunk was seen, but before the 'end' event was fired would also cause weird behavior, and could lead to data being lost, since it would not emit another 'readable' event. This change makes it so that: 1. stream.unshift() does not set state.reading = false 2. stream.unshift() is allowed up until the 'end' event. 3. unshifting onto a EOF-encountered and zero-length (but not yet end-emitted) stream will defer the 'end' event until the new data is consumed. 4. pushing onto a EOF-encountered stream is now an error. So, if you read(), you have that single tick to safely unshift() data back into the stream, even if the null chunk was pushed, and the length was 0.		12 years ago
..
_debugger.js	streams2: Call read(0) on resume()	12 years ago
_linklist.js	Update copyright headers	14 years ago
_stream_duplex.js	stdio: Set readable/writable flags properly	12 years ago
_stream_passthrough.js	stream: _write takes an encoding argument	12 years ago
_stream_readable.js	stream: Fix unshift() race conditions	12 years ago
_stream_transform.js	stream: unused variable	12 years ago
_stream_writable.js	stream: call write cb before finish event	12 years ago
assert.js	assert: Simplify AssertError creation	12 years ago
buffer.js	buffer: fix offset checks	12 years ago
child_process.js	child_process: fix O(n*m) scan of cmd string	12 years ago
cluster.js	lint	12 years ago
console.js	console: Support formatting options in trace()	12 years ago
constants.js	Update copyright headers	14 years ago
crypto.js	crypto: fix constructor call in crypto streams	12 years ago
dgram.js	child_process: support sending dgram socket	12 years ago
dns.js	DNS: Support NAPTR queries	12 years ago
domain.js	domain: fix domain callback from MakeCallback	12 years ago
events.js	events: Handle missing error obj when domains in use	12 years ago
freelist.js	Update copyright headers	14 years ago
fs.js	fs: make write/appendFileSync correctly set file mode	12 years ago
http.js	http: Support write(data, 'hex')	12 years ago
https.js	https: optimize https.createConnection()	12 years ago
module.js	core: Remove the nextTick for running the main file	12 years ago
net.js	lint	12 years ago
os.js	os: rename tmpDir() to tmpdir() for consistency	12 years ago
path.js	lint	12 years ago
punycode.js	punycode: update to v1.2.0	12 years ago
querystring.js	querystring: Removing unnecessary binding	12 years ago
readline.js	events: add check for listeners length	12 years ago
repl.js	repl: use more readable RegExp syntax for spaces	12 years ago
stream.js	events: add check for listeners length	12 years ago
string_decoder.js	Don't allow invalid encodings in StringDecoder class	12 years ago
sys.js	Fix #3577 Un-break require('sys')	13 years ago
timers.js	setTimeout: do not calculate Timeout._when property	12 years ago
tls.js	tls: Re-enable check of CN-ID in cert verification	12 years ago
tty.js	lib, src: remove errno global	12 years ago
url.js	url: make url.format escape delimiters in path and query	12 years ago
util.js	node: Add --throw-deprecation	12 years ago
vm.js	lint	13 years ago
zlib.js	zlib: Manage flush flags appropriately	12 years ago