lukechilds/node - node - Gitea: Git with a cup of tea

Tree: 75f7b2f577

David Benjamin 6ebdb69472 crypto: fix Node_SignFinal PR #11705 switched Node away from using using OpenSSL's legacy EVP_Sign* and EVP_Verify* APIs. Instead, it computes a hash normally via EVP_Digest* and then uses EVP_PKEY_sign and EVP_PKEY_verify to verify the hash directly. This change corrects two problems: 1. The documentation still recommends the signature algorithm EVP_MD names of OpenSSL's legacy APIs. OpenSSL has since moved away from thosee, which is why ECDSA was strangely inconsistent. (This is why "ecdsa-with-SHA256" was missing.) 2. Node_SignFinal copied some code from EVP_SignFinal's internals. This is problematic for OpenSSL 1.1.0 and is missing a critical check that prevents pkey->pkey.ptr from being cast to the wrong type. To resolve this, remove the non-EVP_PKEY_sign codepath. This codepath is no longer necessary. PR #11705's verify half was already assuming all EVP_PKEYs supported EVP_PKEY_sign and EVP_PKEY_verify. Also, in the documentation, point users towards using hash function names which are more consisent. This avoids an ECDSA special-case and some strangeness around RSA-PSS ("RSA-SHA256" is the OpenSSL name of the sha256WithRSAEncryption OID which is not used for RSA-PSS). PR-URL: https://github.com/nodejs/node/pull/15024 Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>		7 years ago
..
aes-gcm-throughput.js	lib,src: fix consistent spacing inside braces	7 years ago
cipher-stream.js	benchmark: fix some RegExp nits	7 years ago
get-ciphers.js	benchmark: fix punycode and get-ciphers benchmark	8 years ago
hash-stream-creation.js	benchmark: fix some RegExp nits	7 years ago
hash-stream-throughput.js	benchmark: fix some RegExp nits	7 years ago
rsa-encrypt-decrypt-throughput.js	benchmark: reduce string concatenations	8 years ago
rsa-sign-verify-throughput.js	crypto: fix Node_SignFinal	7 years ago