lukechilds/node - node - Gitea: Git with a cup of tea

History

Dave 6e11e22081 http: remove excess calls to removeSocket socket.destroy() triggers a 'close' event from the socket which triggers the onClose handler of HTTPAgent which calls self.removeSocket(). So by calling self.removeSocket() prior to socket.destroy() we end up with two calls to self.removeSocket(). If there are pending requests, removeSocket ends up creating a new socket. So if there are pending requests, each time a request completes, we tear down one socket and create two more. So the total number of sockets grows exponentially and without regard for any maxSockets settings. This was noticed in https://github.com/nodejs/node/issues/4050. Let's get rid of the extra calls to removeSocket so we only call it once per completed request. PR-URL: https://github.com/nodejs/node/pull/4172 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com>		9 years ago
..
abort	src: honor --abort_on_uncaught_exception flag	9 years ago
addons	test: fix path to module for repl test on Windows	9 years ago
cctest	deps: check in gtest, add util unit test	10 years ago
debugger	debugger: introduce exec method for debugger	9 years ago
disabled	test: replace deprecated util.debug() calls	9 years ago
fixtures	crypto: load PFX chain the same way as regular one	9 years ago
gc	src: replace usage of v8::Handle with v8::Local	9 years ago
internet	test: eliminate multicast test FreeBSD flakiness	9 years ago
message	src: fix line numbers on core errors	9 years ago
parallel	http: remove excess calls to removeSocket	9 years ago
pummel	test: skip/replace weak crypto tests in FIPS mode	9 years ago
sequential	module,src: do not wrap modules with -1 lineOffset	9 years ago
testpy	test: fix default value for additional param	9 years ago
timers	test: enable linting for tests	10 years ago
.eslintrc	test: make common.js mandatory via linting rule	9 years ago
common.js	test: try other ipv6 localhost alternatives	9 years ago