lukechilds/node - node - Gitea: Git with a cup of tea

Tree: 8621ccc25a

Michaël Zasso 0ae1684396 tools: add ESLint rule for assert.throws arguments The second argument to "assert.throws" is usually a validation RegExp or function for the thrown error. However, the function also accepts a string and in this case it is interpreted as a message for the AssertionError and not used for validation. It is common for people to forget this and pass a validation string by mistake. This new rule checks that we never pass a string literal as a second argument to "assert.throws". Additionally, there is an option to enforce the function to be called with at least two arguments. It is currently off because we have many tests that do not comply with this rule. PR-URL: https://github.com/nodejs/node/pull/10089 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>		8 years ago
..
align-function-arguments.js	tools: make argument alignment linting more strict	8 years ago
align-multiline-assignment.js	tools: remove default parameters from lint rule	9 years ago
assert-fail-single-argument.js	tools: lint rule for assert.fail()	9 years ago
assert-throws-arguments.js	tools: add ESLint rule for assert.throws arguments	8 years ago
buffer-constructor.js	tools: add buffer-constructor eslint rule	9 years ago
new-with-error.js	tools: remove obsolete lint rules	9 years ago
no-let-in-for-declaration.js	tools: avoid let in for loops	8 years ago
no-useless-regex-char-class-escape.js	tools: Add no useless regex char class rule	8 years ago
prefer-assert-methods.js	tools: add eslint rule prefer-assert-methods	8 years ago
require-buffer.js	tools: remove obsolete lint rules	9 years ago
required-modules.js	tools: remove obsolete lint rules	9 years ago