lukechilds/node - node - Gitea: Git with a cup of tea

History

Jeremiah Senkpiel 98de4abae3 tty: use blocking mode on OS X OS X has a tiny 1kb hard-coded buffer size for stdout / stderr to TTYs (terminals). Output larger than that causes chunking, which ends up having some (very small but existent) delay past the first chunk. That causes two problems: 1. When output is written to stdout and stderr at similar times, the two can become mixed together (interleaved). This is especially problematic when using control characters, such as \r. With interleaving, chunked output will often have lines or characters erased unintentionally, or in the wrong spots, leading to broken output. CLI apps often extensively use such characters for things such as progress bars. 2. Output can be lost if the process is exited before chunked writes are finished flushing. This usually happens in applications that use `process.exit()`, which isn't infrequent. See https://github.com/nodejs/node/issues/6980 for more info. This became an issue as result of the Libuv 1.9.0 upgrade. A fix to an unrelated issue broke a hack previously required for the OS X implementation. This resulted in an unexpected behavior change in node. The 1.9.0 upgrade was done in `c3cec1eefc`, which was included in v6.0.0. Full details of the Libuv issue that induced this are at https://github.com/nodejs/node/issues/6456#issuecomment-219974514 Refs: https://github.com/nodejs/node/pull/1771 Refs: https://github.com/nodejs/node/issues/6456 Refs: https://github.com/nodejs/node/pull/6773 Refs: https://github.com/nodejs/node/pull/6816 PR-URL: https://github.com/nodejs/node/pull/6895 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Anna Henningsen <anna@addaleax.net>		9 years ago
..
api	tty: use blocking mode on OS X	9 years ago
api_assets	doc: make the api doc print-friendly	9 years ago
changelogs	doc: improve rendering of v4.4.5 changelog entry	9 years ago
ctc-meetings	Add CTC meeting minutes for 2016-05-04	9 years ago
guides	doc,test: add `How to write a Node.js test` guide	9 years ago
topics	doc: fix broken references	9 years ago
tsc-meetings	doc: add TSC meeting minutes 2015-10-21	9 years ago
full-white-stripe.jpg	build: update Node.js logo on Win installer	9 years ago
node.1	src,module: add --preserve-symlinks command line flag	9 years ago
onboarding-extras.md	doc: improve onboarding-extras.md formatting	9 years ago
onboarding.md	doc: update labels and CI info in onboarding doc	9 years ago
osx_installer_logo.png	build: update Node.js logo on OSX installer	9 years ago
releases.md	doc: update releases.md with new changelog structure	9 years ago
template.html	doc: no Node.js(1)	9 years ago
thin-white-stripe.jpg	build: update Node.js logo on Win installer	9 years ago