lukechilds/node - node - Gitea: Git with a cup of tea

History

Rich Trott 380929ec0c test: remove common.noop This change removes `common.noop` from the Node.js internal testing common module. Over the last few weeks, I've grown to dislike the `common.noop` abstraction. First, new (and experienced) contributors are unaware of it and so it results in a large number of low-value nits on PRs. It also increases the number of things newcomers and infrequent contributors have to be aware of to be effective on the project. Second, it is confusing. Is it a singleton/property or a getter? Which should be expected? This can lead to subtle and hard-to-find bugs. (To my knowledge, none have landed on master. But I also think it's only a matter of time.) Third, the abstraction is low-value in my opinion. What does it really get us? A case could me made that it is without value at all. Lastly, and this is minor, but the abstraction is wordier than not using the abstraction. `common.noop` doesn't save anything over `() => {}`. So, I propose removing it. PR-URL: https://github.com/nodejs/node/pull/12822 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>		8 years ago
..
no_dropped_stdio.js	test: reduce string concatenations	8 years ago
no_dropped_stdio.out	test: test TTY problems by fakeing a TTY using openpty	9 years ago
no_interleaved_stdio.js	test: reduce string concatenations	8 years ago
no_interleaved_stdio.out	test: test TTY problems by fakeing a TTY using openpty	9 years ago
pseudo-tty.status	test: delay child exit in AIX for pseudo-tty tests	8 years ago
ref_keeps_node_running.js	test: remove common.noop	8 years ago
ref_keeps_node_running.out	tty: add ref() so process.stdin.ref() etc. work	8 years ago
stdin-setrawmode.js	test: add test for process.stdin.setRawMode()	8 years ago
stdin-setrawmode.out	test: add stdin-setrawmode.out file	8 years ago
test-handle-wrap-isrefed-tty.js	tty: add ref() so process.stdin.ref() etc. work	8 years ago
test-handle-wrap-isrefed-tty.out	tty: add ref() so process.stdin.ref() etc. work	8 years ago
test-stderr-stdout-handle-sigwinch.js	test: delay child exit in AIX for pseudo-tty tests	8 years ago
test-stderr-stdout-handle-sigwinch.out	test: add test for SIGWINCH handling by stdio.js	8 years ago
test-tty-stdout-end.js	stream: add destroy and _destroy methods.	8 years ago
test-tty-stdout-end.out	test: fix old tty tests	9 years ago
test-tty-wrap.js	test: fix old tty tests	9 years ago
test-tty-wrap.out	test: fix old tty tests	9 years ago
testcfg.py	test: fail for missing output files	8 years ago