lukechilds/node - node - Gitea: Git with a cup of tea

Tree: 99f45b2476

Ben Noordhuis c8c1f96abe src: avoid manual memory management in inspector Make the inspector code easier to reason about by restructuring it to avoid manual memory allocation and copying as much as possible. An amusing side effect is that it reduces the total amount of memory used in the test suite. Before: $ valgrind ./out/Release/cctest 2>&1 \| grep 'total heap' \| cut -c31- 1,017 allocs, 1,017 frees, 21,695,456 allocated After: $ valgrind ./out/Release/cctest 2>&1 \| grep 'total heap' \| cut -c31- 869 allocs, 869 frees, 14,484,641 bytes allocated PR-URL: https://github.com/nodejs/node/pull/7906 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>	9 years ago
..
test_inspector_socket.cc	src: avoid manual memory management in inspector	9 years ago
util.cc	src: make Sec-WebSocket-Key check case-insensitive	9 years ago

Ben Noordhuis c8c1f96abe src: avoid manual memory management in inspector

Make the inspector code easier to reason about by restructuring it
to avoid manual memory allocation and copying as much as possible.

An amusing side effect is that it reduces the total amount of memory
used in the test suite.

Before:

    $ valgrind ./out/Release/cctest 2>&1 | grep 'total heap' | cut -c31-
    1,017 allocs, 1,017 frees, 21,695,456 allocated

After:

    $ valgrind ./out/Release/cctest 2>&1 | grep 'total heap' | cut -c31-
    869 allocs, 869 frees, 14,484,641 bytes allocated

PR-URL: https://github.com/nodejs/node/pull/7906
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

9 years ago

test_inspector_socket.cc

src: avoid manual memory management in inspector

9 years ago

util.cc

src: make Sec-WebSocket-Key check case-insensitive

9 years ago