lukechilds/node - node - Gitea: Git with a cup of tea

History

Gabriel Schulhof cb94905774 n-api: stop creating references to primitives The binding testing napi_wrap() creates references to primitives passed into the binding in its second parameter. This is unnecessary and not at all the point of the test. Additionally, creating persistent references to primitive values may not be supported by all VMs, since primitives are best persisted in their native form. Instead, the point of the test is to make sure that the finalize callback gets called when it should get called, that it gets called with the correct pointer, and that it does not get called when it should not get called. Creating persistent references is not necessary for verifying this. PR-URL: https://github.com/nodejs/node/pull/15289 Reviewed-By: Jason Ginchereau <jasongin@microsoft.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Re: https://github.com/nodejs/node-chakracore/issues/380		8 years ago
..
api	n-api: stop creating references to primitives	8 years ago
api_assets	doc: add links to alternative versions of doc	8 years ago
changelogs	2017-09-12, Version 8.5.0 (Current)	8 years ago
guides	http2: fix documentation nits	8 years ago
.eslintrc.yaml	tools: remove legacy indentation linting	8 years ago
STYLE_GUIDE.md	doc: update backporting guide	8 years ago
full-white-stripe.jpg	build: update Node.js logo on Win installer	9 years ago
node.1	doc: environmental->environment & NodeJS->Node.js	8 years ago
onboarding-extras.md	doc: describe labelling process for backports	8 years ago
onboarding.md	meta: merge TSC and CTC back into a single body	8 years ago
osx_installer_logo.png	build: update Node.js logo on OSX installer	9 years ago
releases.md	tools: checkout for unassigned DEP00XX codes	8 years ago
template.html	doc: add links to alternative versions of doc	8 years ago
thin-white-stripe.jpg	build: update Node.js logo on Win installer	9 years ago