You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Gabriel Schulhof
cb94905774
n-api: stop creating references to primitives The binding testing napi_wrap() creates references to primitives passed
into the binding in its second parameter. This is unnecessary and not
at all the point of the test. Additionally, creating persistent
references to primitive values may not be supported by all VMs, since
primitives are best persisted in their native form.
Instead, the point of the test is to make sure that the finalize
callback gets called when it should get called, that it gets called
with the correct pointer, and that it does not get called when it
should not get called. Creating persistent references is not necessary
for verifying this.
PR-URL: https://github.com/nodejs/node/pull/15289
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Re: https://github.com/nodejs/node-chakracore/issues/380
8 years ago
..
1_hello_world
test,doc: make module name match gyp target name
8 years ago
2_function_arguments
test,doc: make module name match gyp target name
8 years ago
3_callbacks
test,doc: make module name match gyp target name
8 years ago
4_object_factory
test,doc: make module name match gyp target name
8 years ago
5_function_factory
test,doc: make module name match gyp target name
8 years ago
6_object_wrap
test,doc: make module name match gyp target name
8 years ago
7_factory_wrap
test,doc: make module name match gyp target name
8 years ago
8_passing_wrapped
test,doc: make module name match gyp target name
8 years ago
test_array
test,doc: make module name match gyp target name
8 years ago
test_async
test,doc: make module name match gyp target name
8 years ago
test_buffer
test,doc: make module name match gyp target name
8 years ago
test_constructor
test,doc: make module name match gyp target name
8 years ago
test_conversions
test,doc: make module name match gyp target name
8 years ago
test_dataview
test,doc: make module name match gyp target name
8 years ago
test_env_sharing
test,doc: make module name match gyp target name
8 years ago
test_error
test,doc: make module name match gyp target name
8 years ago
test_exception
test,doc: make module name match gyp target name
8 years ago
test_fatal
test,doc: make module name match gyp target name
8 years ago
test_function
test,doc: make module name match gyp target name
8 years ago
test_general
n-api: stop creating references to primitives
8 years ago
test_handle_scope
test,doc: make module name match gyp target name
8 years ago
test_make_callback
test,doc: make module name match gyp target name
8 years ago
test_make_callback_recurse
test,doc: make module name match gyp target name
8 years ago
test_number
test,doc: make module name match gyp target name
8 years ago
test_object
test,doc: make module name match gyp target name
8 years ago
test_promise
test,doc: make module name match gyp target name
8 years ago
test_properties
test,doc: make module name match gyp target name
8 years ago
test_reference
test,doc: make module name match gyp target name
8 years ago
test_string
test,doc: make module name match gyp target name
8 years ago
test_symbol
test,doc: make module name match gyp target name
8 years ago
test_typedarray
test,doc: make module name match gyp target name
8 years ago
.gitignore
n-api: add support for abi stable module API
8 years ago
common.h
n-api: add code parameter to error helpers
8 years ago
testcfg.py
n-api: add support for abi stable module API
8 years ago
Gabriel Schulhof
cb94905774