lukechilds/node - node - Gitea: Git with a cup of tea

History

Alexey Orlenko 9e4660b518 zlib: fix node crashing on invalid options This commit fixes the Node process crashing when constructors of classes of the zlib module are given invalid options. * Throw an Error when the zlib library rejects the value of windowBits, instead of crashing with an assertion. * Treat windowBits and memLevel options consistently with other ones and don't crash when non-numeric values are given. * Fix bugs in the validation logic: - Don't conflate 0 and undefined when checking if a field of an options object exists. - Treat NaN and Infinity values the same way as values of invalid types instead of allowing to actually set zlib options to NaN or Infinity. PR-URL: https://github.com/nodejs/node/pull/13098 Fixes: https://github.com/nodejs/node/issues/13082 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>		8 years ago
..
api	zlib: fix node crashing on invalid options	8 years ago
api_assets	doc: reduce font size on smaller screens	8 years ago
changelogs	doc: fix links from ToC to subsection for 4.8.x	8 years ago
guides	doc: update doc to remove usage of "you"	8 years ago
.eslintrc.yaml	doc: add no-var, prefer-const in doc eslintrc	8 years ago
STYLE_GUIDE.md	doc: change Mac OS X to macOS	8 years ago
full-white-stripe.jpg	build: update Node.js logo on Win installer	9 years ago
node.1	src: allow CLI args in env with NODE_OPTIONS	8 years ago
onboarding-extras.md	doc: add suggestion to use --3way	8 years ago
onboarding.md	doc: correct git fix whitespace command	8 years ago
osx_installer_logo.png	build: update Node.js logo on OSX installer	9 years ago
releases.md	doc: update Mac OS X references in releases.md	8 years ago
template.html	tools,doc: add Google Analytics tracking.	8 years ago
thin-white-stripe.jpg	build: update Node.js logo on Win installer	9 years ago