lukechilds/node - node - Gitea: Git with a cup of tea

History

Sakthipriyan Vairamani (thefourtheye) ee14690503 buffer: coerce slice parameters consistently As shown in https://github.com/nodejs/node/issues/9096, the offset and end value of the `slice` call are coerced to numbers and then passed to `FastBuffer`, which internally truncates the mantissa part if the number is actually a floating point number. This actually affects the new length of the slice calculation. For example, > const original = Buffer.from('abcd'); undefined > original.slice(original.length / 3).toString() 'bc' This happens because, starting value of the slice is 4 / 3, which is 1.33 (approximately). Now, the length of the slice is calculated as the difference between the actual length of the buffer and the starting offset. So, it becomes 2.67 (4 - 1.33). Now, a new `FastBuffer` is constructed, with the following values as parameters, 1. actual buffer object, 2. starting value, which is 1.33 and 3. the length 2.67. The underlying C++ code truncates the numbers and they become 1 and 2. That is why the result is just `bc`. This patch makes sure that all the offsets are coerced to integers before any calculations are done. Fixes: https://github.com/nodejs/node/issues/9096 PR-URL: https://github.com/nodejs/node/pull/9101 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>		8 years ago
..
internal	process: improve performance of nextTick	8 years ago
.eslintrc	tools: avoid let in for loops	8 years ago
_debug_agent.js	debugger: use arrow function for lexical `this`	8 years ago
_debugger.js	debugger: remove obsolete setTimeout	8 years ago
_http_agent.js	http: name anonymous functions	8 years ago
_http_client.js	http: name anonymous functions in _http_client	8 years ago
_http_common.js	http: fix connection upgrade checks	8 years ago
_http_incoming.js	http: name anonymous functions in _http_incoming	8 years ago
_http_outgoing.js	http: name anonymous functions in _http_outgoing	8 years ago
_http_server.js	http: name anonymous functions in _http_server	8 years ago
_linklist.js	lib: use emitWarning instead of printDeprecationMessage	8 years ago
_stream_duplex.js	node: allow multiple arguments passed to nextTick	10 years ago
_stream_passthrough.js	lib: use const to define constants	10 years ago
_stream_readable.js	lib: remove let from for loops	8 years ago
_stream_transform.js	src: fixes misplaced comment	8 years ago
_stream_wrap.js	stream_wrap: error if stream has StringDecoder	9 years ago
_stream_writable.js	stream: fix `Writable` subclass instanceof checks	8 years ago
_tls_common.js	tls: improve createSecureContext in _tls_common	8 years ago
_tls_legacy.js	lib: replace legacy uses of __defineGetter__	9 years ago
_tls_wrap.js	tls: TLSSocket emits 'error' on handshake failure	8 years ago
assert.js	tools: replace custom ESLint rule with built-in	8 years ago
buffer.js	buffer: coerce slice parameters consistently	8 years ago
child_process.js	child_process: update outdated comment	8 years ago
cluster.js	cluster: remove unused backlog argument	8 years ago
console.js	console: name anonymous functions	8 years ago
constants.js	src: refactor require('constants')	9 years ago
crypto.js	crypto: naming anonymous functions	8 years ago
dgram.js	dgram: use Buffer.alloc(0) for zero-size buffers	8 years ago
dns.js	dns: name anonymous functions	8 years ago
domain.js	domain: add message for dispose deprecation	8 years ago
events.js	events: make memory leak warning name more verbose	8 years ago
fs.js	fs: don't alter user provided `options` object	8 years ago
http.js	http: name anonymous functions in http	8 years ago
https.js	crypto: fail early when loading crypto without openssl	9 years ago
module.js	module: Remove deprecated function requireRepl.	8 years ago
net.js	net: fix ambiguity in EOF handling	8 years ago
os.js	os: deprecate `tmpDir()` in favour of `tmpdir()`	8 years ago
path.js	path: fallback to process cwd when resolving drive cwd	8 years ago
process.js	src: remove excessive license boilerplate	10 years ago
punycode.js	lib: remove let from for loops	8 years ago
querystring.js	benchmark,test,lib: remove extra spaces	9 years ago
readline.js	readline: fix `concievably` typo in readline.js	8 years ago
repl.js	lib: remove let from for loops	8 years ago
stream.js	lib,src: remove usage of events.EventEmitter	9 years ago
string_decoder.js	string_decoder: fix bad utf8 character handling	8 years ago
sys.js	lib: use emitWarning instead of printDeprecationMessage	8 years ago
timers.js	timers: fix regression with clearImmediate()	8 years ago
tls.js	lib: remove let from for loops	8 years ago
tty.js	tty: set the handle to blocking mode	8 years ago
url.js	url: adding WHATWG URL support	8 years ago
util.js	lib: remove let from for loops	8 years ago
v8.js	lib: remove let from for loops	8 years ago
vm.js	vm: change ContextifyScript to Script in comment	8 years ago
zlib.js	zlib: move constants into zlib.constants	8 years ago