lukechilds/node - node - Gitea: Git with a cup of tea

History

Dan Fabulich 7b5ffa46fe fs,doc: undeprecate existsSync This has been dragged through various long discussions and has been elevated to the CTC multiple times. As noted in https://github.com/nodejs/node/pull/7455#issuecomment-228961530, while this API is still generally considered an anti-pattern, there are still use-cases it is best suited for, such as checking if a git rebase is in progress by looking if ".git/rebase-apply/rebasing" exists. The general consensus is to undeprecate just the sync version, given that the async version still has the "arguments order inconsistency" problem. The consensus at the two last CTC meetings this came up at was also to undeprecate existsSync() but keep exists() deprecated. See: https://github.com/nodejs/node/issues/8242 & https://github.com/nodejs/node/issues/8330 (Description write-up by @Fishrock123) Fixes: https://github.com/nodejs/node/issues/1592 Refs: https://github.com/nodejs/node/pull/4217 Refs: https://github.com/nodejs/node/pull/7455 PR-URL: https://github.com/nodejs/node/pull/8364 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>		8 years ago
..
api	fs,doc: undeprecate existsSync	8 years ago
api_assets	doc: make the api doc print-friendly	9 years ago
changelogs	2016-09-27, Version 6.7.0 (Current)	8 years ago
ctc-meetings	doc: add CTC meeting minutes 2016-09-14	8 years ago
guides	doc: recommend using port 0 instead of common.PORT	8 years ago
topics	doc: enable no-file-name-articles remark-lint rule	8 years ago
tsc-meetings	tools: enable more remark-lint rules	8 years ago
full-white-stripe.jpg	build: update Node.js logo on Win installer	9 years ago
node.1	tty: set the handle to blocking mode	8 years ago
onboarding-extras.md	doc: enable first-heading-level remark-lint rule	8 years ago
onboarding.md	doc: encourage 2FA before onboarding	8 years ago
osx_installer_logo.png	build: update Node.js logo on OSX installer	9 years ago
releases.md	doc: add commit formats for release blog posts	8 years ago
template.html	doctool: improve the title of pages in doc	9 years ago
thin-white-stripe.jpg	build: update Node.js logo on Win installer	9 years ago