hmset throws/errors out on non-string values. fixes #218

README.md

@@ -277,7 +277,7 @@ Output:
 Multiple values in a hash can be set by supplying an object:
 
     client.HMSET(key2, {
-        "0123456789": "abcdefghij",
+        "0123456789": "abcdefghij", // NOTE: the key and value must both be strings
         "some manner of key": "a type of value"
     });
 

index.js

@@ -898,6 +898,11 @@ RedisClient.prototype.hmset = function (args, callback) {
         for (i = 0, il = tmp_keys.length; i < il ; i++) {
             key = tmp_keys[i];
             tmp_args.push(key);
+            if (typeof args[1][key] !== "string") {
+                var err = new Error("hmset expected value to be a string", key, ":", args[1][key]);
+                if (callback) return callback(err);
+                else throw err;
+            }
             tmp_args.push(args[1][key]);
         }
         args = tmp_args;

test.js

@@ -1348,6 +1348,24 @@ tests.OPTIONAL_CALLBACK_UNDEFINED = function () {
     client.get("op_cb2", last(name, require_string("y", name)));
 };
 
+tests.HMSET_THROWS_ON_NON_STRINGS = function () {
+    var name = "HMSET_THROWS_ON_NON_STRINGS";
+    var hash = name;
+    var data = { "a": [ "this is not a string" ] };
+
+    client.hmset(hash, data, cb);
+    function cb(e, r) {
+        assert(e); // should be an error!
+    }
+
+    // alternative way it throws
+    function thrower() {
+        client.hmset(hash, data);
+    }
+    assert.throws(thrower);
+    next(name);
+};
+
 // TODO - need a better way to test auth, maybe auto-config a local Redis server or something.
 // Yes, this is the real password.  Please be nice, thanks.
 tests.auth = function () {