1b8201e542
Merge pull request #856 from cvibhagool/patch-1
Fixed typo in README.md
9 years ago
2c67ce528e
Fixed typo in README.md
9 years ago
97db227a8d
Fix for channel names with spaces. Fixes #691
Channel names with spaces were not properly resubscribed after a reconnection.
Conflicts:
index.js
10 years ago
b35a685c27
Merge pull request #855 from fintura/info
Improve server keyspace info in .server_info. Closing #610 . Thx to @SinisterLight
9 years ago
28f31f134c
Improve server keyspace info in .server_info
9 years ago
a6357d672a
Merge pull request #854 from fintura/memory-leak
Fix memory leak. See #723 and thx to @rahar
9 years ago
46e2dc2de5
Fix memory leak. See #723 and thx to @rahar
9 years ago
c846ed71d1
Merge pull request #826 from fintura/multi
Fix multi error handling
9 years ago
4d1390318c
Merge pull request #853 from fintura/eval
Remove bad .eval implementation
9 years ago
2578aba079
Merge pull request #848 from fintura/new_auth
Fix auth callback being called more than once
9 years ago
d61d97e24e
Fix .auth not working properly
The arguments parameter was faulty andthe callback could have been triggered twice
9 years ago
8b7d4a8449
Remove bad .eval implementation
The implementation is not really good as mentioned in #722 and we pipline our commands.
That way we can't just replace the eval function as it was. This could result in violating the order of execution!
If we want to include a function like this we should not break the order of execution and also not recalculate the sha1 hash each time.
9 years ago
21d8bdbbcb
Refactor multi to have a consistent error handling
Ignore *.log files
9 years ago
13635c9c8c
Merge pull request #840 from fintura/refactor-exec
This fixes two TODOs in combination with exec
9 years ago
9e2c665d5c
Refactor exec
9 years ago
95a2c373a2
Fix broken build. The merge had a small conflict
9 years ago
f92f4d0df9
Merge pull request #850 from fintura/fix-late-commands
Fix commands not being rejected after calling .quit
Fixes #791
9 years ago
bfcc0ae263
Merge pull request #843 from fintura/reduce-timeout
Reduce the reauthenticate timeout to 333ms
9 years ago
57b5c7f76f
Merge pull request #829 from fintura/broken-mode
Implement redis connection broken mode and more shiny things
Fixes #569
Fixes #587
Fixes #566
Fixes #586
Fixes #280
This includes the fixes as suggested in #671 , #615 and #533 . Thx a lot to @qdb , @tobek and @chrishamant
Closes #675 , #463 , #362 , #438 and #724
9 years ago
a0c906256c
Fix commands not being rejected after calling .quit as reported in #791
9 years ago
89c8dd056b
Do not emit the broken mode twice if exec is called
Add more tests
9 years ago
30ec1cd6a2
shift in the while loop
9 years ago
55d0036eae
Add test and fix keeping the offline queue
Use a new delay after reconnecting
9 years ago
3c2ba8c373
Try exactly until the connection timeout has been reached
Fixes #587
9 years ago
a9e7663aff
removing flush_and_error from on_error handler
11 years ago
03e8c03503
Add connection timeout and max attempts tests
9 years ago
0b8705abe9
Do not run all tests with every single connection (if one connection works, the others are going to be fine too)
9 years ago
1e0421ac3b
Emit errors if the connection timeout / maximum retry attempts have been exceeded
Accept setting max_attempts to zero.
The reconnection event is now emitted when trying to reconnect instead of earlier.
The connection timeout is now going to trigger once after exceeding the maximum timeout instead of stopping earlier.
9 years ago
f2ee8dbc9e
Add a connection timeout of 24h as new default for maximum reconnecting
9 years ago
04c986a4cd
Lowering the first retry_delay and begin from that value
Earlier the first value was never used, as it was first multiplied by 1.7
9 years ago
cd5cfb4a8e
Emit an error when connection permanently goes down
Closes #724 and #615
9 years ago
403bfb0200
Merge pull request #835 from fintura/remove-stuff
Remove send_command safety checks. Fixes #629
9 years ago
eea9d2af76
Merge pull request #847 from fintura/check-password
Check that the password is from type string
9 years ago
30f227b7b1
Merge pull request #846 from fintura/parser
Improve js parser
9 years ago
aab1fc8f4f
Merge pull request #838 from fintura/consistent-commands
Consistent commands arguments. All commands are from now on behaving the same no matter if they are on multi or no and they all take an array as either the first or second argument.
Fixes #686 #369 #422 #390 and Closes #634
9 years ago
005e869d83
Remove send_command safety checks
This checks are only important for users who use send_command directly instead of using the convience method.
As the readme clearly stats how send_command should work and any user would have run into errors if misused, these checks can be removed. If any user might misuse the function anyway, it is very likely that another error will be thrown because of that
Fix #629 and insert tests
9 years ago
013831c00f
Improve js parser
9 years ago
c269b7539c
Check that the password is from type string
9 years ago
a0c92b0756
Add a lot more tests to indicate that the everything is consistent
Add a test for #390
More special cases
9 years ago
c522ca1264
Fix inconsistent command argument handling
Earlier multi.command and client.command diverged a lot in the way they accepted arguments. This is now consistent
This will also fix some bugs like using multi.hmset with arrays
9 years ago
e24f056b2d
Merge pull request #841 from fintura/command
Add .command_used to errors returned by the parser.
Fix authentication failure being emitted instead of returned by a callback if present. Fixes #427
9 years ago
ebbb0146b9
Fix auth emitting the error even though a callback is present
Fix auth manipulating the returned error
And this is also removing some dead code
9 years ago
1a06cfb6ec
Add .command_used to errors thrown by the parser
9 years ago
e4bd9bf0c5
Merge pull request #839 from fintura/statements
Small stuff like: let v8 inline instead of doing in manually
9 years ago
6ea70271d6
v8 is going to inline a couple of things that were necessary a few years ago
9 years ago
4bdcf8a598
Fix regression: version detection in tests did not work properly anymore
9 years ago
785af29385
Merge pull request #842 from fintura/speedup
Small speedup: do not call data.toString() on debug messages
9 years ago
4a8da6dce5
Merge pull request #823 from fintura/debug
Refactor debug mode not to break old code and to work with NODE_DEBUG too
9 years ago
4f79370887
Merge pull request #816 from fintura/callback
Remove try callback and emit errors if no callback is present. Fixes #456 , #591 , #522 and #755
9 years ago
4f0443cdd4
Emit errors instead of throwing them
Thrown errors might kill the users app. By emitting the errors the user is able to catch all errors in one place without the app going down
9 years ago
Ruben Bridgewater
Ben Vibhagool
pbihler
Ruben Bridgewater
Chris Hamant