From 2cd38a2b15ff5618c86833c8e7bbd8c2f0731fab Mon Sep 17 00:00:00 2001 From: Jack Cross Date: Tue, 17 Jan 2017 09:34:44 -0500 Subject: [PATCH] Add Flow reminder to PR template (#8805) * Added flow to PR template * Added record-tests step to PR template and contribution docs * Updated order of PR checks --- contributing/how-to-contribute.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/contributing/how-to-contribute.md b/contributing/how-to-contribute.md index 4beaabea..e1a10c74 100644 --- a/contributing/how-to-contribute.md +++ b/contributing/how-to-contribute.md @@ -82,7 +82,8 @@ The core team is monitoring for pull requests. We will review your pull request 4. Ensure the test suite passes (`npm test`). 5. Make sure your code lints (`npm run lint`). 6. Run the [Flow](https://flowtype.org/) typechecks (`npm run flow`). -7. If you haven't already, complete the CLA. +7. If you added or removed any tests, run `./scripts/fiber/record-tests` before submitting the pull request, and commit the resulting changes. +8. If you haven't already, complete the CLA. ### Contributor License Agreement (CLA)