From 4a4a9596fb899821fe28b199a738000c023efcc9 Mon Sep 17 00:00:00 2001 From: renanpvaz Date: Fri, 13 Oct 2017 13:02:56 -0300 Subject: [PATCH 1/3] mention ad blockers when babel is not defined --- src/components/CodeEditor/CodeEditor.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/components/CodeEditor/CodeEditor.js b/src/components/CodeEditor/CodeEditor.js index cfe88135..4f50ef69 100644 --- a/src/components/CodeEditor/CodeEditor.js +++ b/src/components/CodeEditor/CodeEditor.js @@ -177,6 +177,7 @@ class CodeEditor extends Component { padding: 10, }}> {error.message} + {!window.Babel && ' (try checking your ad blocker if you have one).'} )} From 4ab3ae3685bc56bb278b52f334620dd562fa7d5c Mon Sep 17 00:00:00 2001 From: renanpvaz Date: Fri, 13 Oct 2017 13:22:48 -0300 Subject: [PATCH 2/3] prettier --- src/components/CodeEditor/CodeEditor.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/components/CodeEditor/CodeEditor.js b/src/components/CodeEditor/CodeEditor.js index 4f50ef69..5ef5fff7 100644 --- a/src/components/CodeEditor/CodeEditor.js +++ b/src/components/CodeEditor/CodeEditor.js @@ -177,7 +177,8 @@ class CodeEditor extends Component { padding: 10, }}> {error.message} - {!window.Babel && ' (try checking your ad blocker if you have one).'} + {!window.Babel && + ' (try checking your ad blocker if you have one).'} )} From 26c975de3b00098bab307dee88be08910cbeecc3 Mon Sep 17 00:00:00 2001 From: renanpvaz Date: Mon, 16 Oct 2017 16:19:07 -0200 Subject: [PATCH 3/3] use flag to show custom message instead of error --- src/components/CodeEditor/CodeEditor.js | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/src/components/CodeEditor/CodeEditor.js b/src/components/CodeEditor/CodeEditor.js index 5ef5fff7..5fede1c0 100644 --- a/src/components/CodeEditor/CodeEditor.js +++ b/src/components/CodeEditor/CodeEditor.js @@ -176,9 +176,16 @@ class CodeEditor extends Component { color: colors.error, padding: 10, }}> - {error.message} - {!window.Babel && - ' (try checking your ad blocker if you have one).'} + {this.state.didBabelLoad ? ( + error.message + ) : ( + + Babel could not be loaded. This can be caused by ad + blockers. If you're using an ad blocker, consider adding + reactjs.org to the whitelist so the live code examples + will work. + + )} )} @@ -277,6 +284,7 @@ class CodeEditor extends Component { console.error(error); return { + didBabelLoad: !!window.Babel, compiled: null, error, };