Browse Source

[Beta] Add ARIA labels (#4335)

* Add ARIA labels

* Remove unnecessary ARIA label

* Add Facebook and Twitter ARIA labels
main
Sha Mwe La 3 years ago
committed by GitHub
parent
commit
b4de7008f3
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      beta/src/components/Layout/Footer.tsx
  2. 1
      beta/src/components/Layout/Nav/Nav.tsx
  3. 1
      beta/src/components/Search.tsx

2
beta/src/components/Layout/Footer.tsx

@ -126,11 +126,13 @@ export function Footer() {
</FooterLink>
<div className="flex flex-row mt-8 gap-x-2">
<ExternalLink
aria-label="React on Facebook"
href="https://www.facebook.com/react"
className={socialLinkClasses}>
<IconFacebookCircle />
</ExternalLink>
<ExternalLink
aria-label="React on Twitter"
href="https://twitter.com/reactjs"
className={socialLinkClasses}>
<IconTwitter />

1
beta/src/components/Layout/Nav/Nav.tsx

@ -173,6 +173,7 @@ export default function Nav() {
<div className="flex my-4 h-10 mx-0 w-full lg:hidden justify-end slg:max-w-sm">
<Search />
<button
aria-label="Give feedback"
type="button"
className="inline-flex lg:hidden items-center p-1 ml-4 lg:ml-6 relative top-px"
onClick={handleFeedback}>

1
beta/src/components/Search.tsx

@ -95,6 +95,7 @@ export const Search: React.FC<SearchProps> = ({
</Head>
<button
aria-label="Search"
type="button"
className="inline-flex md:hidden items-center text-lg p-1 ml-4 lg:ml-6"
onClick={onOpen}>

Loading…
Cancel
Save