Adam Saghy
2ea33ffc3d
Update conditional-rendering.md ( #990 )
`componentWillUpdate` method will be called before the render method so the returning value of the render method does not affect.
7 years ago
Stephen Lau
61a8b62b03
Mention getSnapshotBeforeUpdate should return. ( #930 )
If getSnapshotBeforeUpdate does not return a snapshot value or null
it will cause a warning. Document that it should return this value.
7 years ago
Rodrigo Bermúdez Schettino
24f0448d7c
Update Ref API in docs ( #970 )
* Update Ref API in docs
Update to new React.createRef() API in guide "Uncontrolled Components".
* Update Ref API in doc example
Use new Ref API in guide's example.
* Fix syntax error in example
* Update highlighting ranges in docs
After updating to the new createRef API, the highlighting ranges in Uncontrolled Components were wrong.
* Update highlighting ranges in docs example
After updating to the new createRef API, the highlighting ranges in Uncontrolled Components were wrong.
* Update highlighting ranges in docs example
Remove empty line in source code.
* Update uncontrolled-components.md
* Update input-type-file.js
7 years ago
Sophie Alpert
5045e82b2a
Clarify class lifetime in class conversion example ( #912 )
* Clarify class lifetime in class conversion example
* Update state-and-lifecycle.md
7 years ago
Jonathan Berger
c47933a314
Correct typo in FAQ ( #985 )
Correcting a small typo.
7 years ago
Andy Edwards
af3b37ece3
docs(forwarding-refs.md): add warning to third-party library maintainers ( #968 )
* docs(forwarding-refs.md): add warning to third-party library maintainers
* Update forwarding-refs.md
* Update forwarding-refs.md
* Update forwarding-refs.md
* tweaks
7 years ago
Alex Krolick
ee650c8b30
Reorganize Hello World Page ( #962 )
* Reorganize Hello World Page
Move codeblock to the very top and and "following along" heading
* Match tense
* Remove subheading
7 years ago
Dan Abramov
81dc09ede1
Make the reference doc tighter
Now that there are some cross referenced links we can tighten it up.
7 years ago
Dan Abramov
17c50df9d9
Explicitly order Main Concepts ( #957 )
7 years ago
Dan Abramov
853f3d1945
Quick Start -> Main Concepts ( #956 )
7 years ago
Dan Abramov
d430480318
Reorder advanced guides by alphabet
I think this way it's clearer they're unordered, thus making it clearer Quick Start *is* ordered.
7 years ago
Dan Abramov
f5b284e101
Remove misleading paragraph
This was never true
7 years ago
Dan Abramov
c9e99c8ae6
Avoid unnecessary ternary
7 years ago
Dan Abramov
c70187cdbf
Cross-link more articles
7 years ago
Dan Abramov
a788a28708
Avoid ambiguity between elements and components
7 years ago
Dan Abramov
3346d710b9
Clarify we are talking about sync calls
7 years ago
Dan Abramov
4550cb0e6a
Massage the section more and add details
7 years ago
Jenny Wong
941c1a4efc
NOtes and ideas for hello-world.md file.
- you can _just_ open it in
- It _renders_ a heading saying “Hello, world!” on the page. - you are using the same word as the thing you are describing.
- “A Note on JavaScript” the title doe snot suggest that you need to read it because you are learning about react ,not JS. Something like “React & JavaScript” or something like “Knowledge Level Assumptions”
- “we recommend **refreshing** your JavaScript knowledge so you can follow along more easily.” — refreshing suggest that someone. Already knows JS, so if they don’t know JS they will feel dejected. Try “We highly recommend [going through a Javascript tutorial]() to check your knowledge level.”
- “We also use some of the ES6 syntax” - **We** that suggests its a us vs the user. Instead go for “**The documentation** will use some [ES6 Syntax](LINK TO WHAT IS ES6)”
7 years ago
Dan Abramov
640ac1397b
No "just"
7 years ago
Dan Abramov
f285d002c5
Reduce visual noise in the list
It's obvious enough that this is the same method. I don't think repeating its name in the list brings any value, and it puts too much visual emphasis on something we're trying to deemphasize.
7 years ago
Dan Abramov
4f01e35b9d
Rewrite some component doc parts
7 years ago
Dan Abramov
6fe2302aed
Don’t make experienced users feel bad
7 years ago
Dan Abramov
7603eb964b
Mark common lifecycles as bold ( #948 )
7 years ago
Dan Abramov
79411aa85b
Reorder and rewrite some parts of lifecycle reference ( #947 )
* Reorder and rewrite some parts of lifecycle reference
* Link to the lifecycle diagram
* More recommendations
7 years ago
Sébastien Boulet
95112711bb
fix link to anchor #unsafe_componentwillupdate ( #920 )
7 years ago
Sophie Alpert
3e87993047
Move static type checking above PropTypes
7 years ago
Brian Vaughn
3e80980c18
Renamed params for gDSFP
7 years ago
Andrew Clark
983476e3f3
Update getDerivedStateFromProps docs
7 years ago
Philipp Spiess
a1f41f65a2
Don’t recommend PEP because it lacks features
7 years ago
Philipp Spiess
988a67739d
Add section about Pointer Events
This PR adds a section about the state of Pointer Events in React.
This should be merged only if facebook/react#12507 is accepted as well.
7 years ago
John Park
665ccbf907
Missing closing quotation in line 225 for <Button /> ( #905 )
7 years ago
pushpinder107
06f8553e90
Fixes typo ( #902 )
7 years ago
Dan Burzo
1d5217a293
Clarify change propagation in Context API ( #896 )
7 years ago
barnonahill
9b72ba6f05
Add a sentence to the end of componentWillUnmount() ( #894 )
Adds a sentence explaining not to use setState in componentWillUnmount, see https://github.com/facebook/react/issues/12111
7 years ago
cyan33
5ce098c1a1
refactor the wording
7 years ago
cyan33
1b5cf20dcc
add #detecting legacy context apis for strict mode post
7 years ago
Tung Vu
1f8fdac9cc
doc: add createRef to Refs glossary ( #875 )
* doc: add createRef to Refs glossary
* doc: move newer api first
7 years ago
Stephane Moreau
f03e9c785d
"Introducing JSX" is missing a step ( #812 )
* Introducing JSX is missing a step
* Tweak
7 years ago
Alex Krolick
c95de8b59a
Clarify defaultValue usage ( #868 )
Fixes #867
7 years ago
Duc Nghiem Xuan
d0cdc9ef0c
Fix elmish-react link on static-type-checking ( #857 )
`fable-elmish` org is now simply `elmish`, thus the link to `elmish-react` was 404.
ref https://github.com/elmish/elmish/issues/145
7 years ago
Dan Abramov
e3cf355618
Tweak componentWillReceiveProps docs ( #856 )
* Tweak componentWillReceiveProps docs
* Update reference-react-component.md
7 years ago
Rauno Freiberg
3279bd768b
Fix JSX link in design principles section ( #855 )
7 years ago
Chester Law
f97629e6f0
Fix grammar in List and Keys documentation ( #854 )
7 years ago
Augustus Yuan
f1bdc9674e
Replace meeting notes section with RFCS section ( #848 )
7 years ago
Eugene Kopich
f40682a583
new "Flow" URL (2) ( #839 )
7 years ago
Eugene Kopich
b147d01e75
new "Flow" URL ( #838 )
7 years ago
Jedai Saboteur
049c40109d
Linked to an example "from scratch" implementation ( #837 )
* Add link to complete example
* Fix heading space on complete example
7 years ago
Joep van der Heijden
1c9b6139c4
Add missing semicolon in example code ( #835 )
7 years ago
Michael Li
ed255e604b
Fix grammar
7 years ago
J Silverstein
380225e65e
add chromevox to a11y documentation
7 years ago