Tree: d2d7ba16f1

lukechilds-patch-1

main

Branches Tags

${ item.name }

Create tag ${ searchTerm }

Create branch ${ searchTerm }

from 'd2d7ba16f1'

${ noResults }

Commit Graph

3 Commits (d2d7ba16f161dcaa8a3321e9370997d7740a26d7)

Author	SHA1	Message	Date
Will Myers	35bb6edcbb	Update blog post which creates unhandled promise rejection (#9668) * Update 2015-12-16-ismounted-antipattern.md In case anybody else stumbles across this old blog post, I wanted to submit a patch to help with unhandled rejections. `#then` and `#catch` each return new Promise instances, so here we actually create two new promises (that aren't assigned). If the argument promise to `#makeCancelable` rejects, the promise created by `#then` will be an unhandled rejection, which in Node 7 will be an uncaught error. By using the second argument of `#then` to handle rejections instead, we don't need to worry about the runtime finding any unhandled rejections here. * Style updates * Add update notice	8 years ago
jim	d4730c162d	Updated code fragment for correctness.	9 years ago
Jim	eeaf72f9aa	Added post about upgrading your code to avoid isMounted()	9 years ago