Move jQuery out of the bundle (#545)

.gitignore

@@ -1,3 +1,4 @@
 node_modules
 extension/**/*.js
 extension/**/*.map
+!extension/jquery-3.slim.min.js

extension/manifest.json

@@ -43,6 +43,7 @@
 				"content.css"
 			],
 			"js": [
+				"jquery-3.slim.min.js",
 				"content.js"
 			]
 		}

package.json

@@ -9,7 +9,7 @@
     "watch:sourcemap": "cross-env SOURCEMAP=true npm run watch --silent",
     "release:amo": "cd extension && webext submit",
     "release:cws": "cd extension && webstore upload --auto-publish",
-    "release": "run-s build update-version release:cws",
+    "release": "run-s build update-version release:*",
     "update-version": "dot-json extension/manifest.json version $(date -u +%y.%-m.%-d.%-H%M)"
   },
   "dependencies": {
@@ -45,6 +45,7 @@
   "xo": {
     "envs": [
       "browser",
+      "jquery",
       "webextensions"
     ],
     "rules": {

src/content.js

@@ -7,7 +7,6 @@ import toSemver from 'to-semver';
 import linkifyIssues from 'linkify-issues';
 import select from 'select-dom';
 import domLoaded from 'dom-loaded';
-import $ from './libs/vendor/jquery.slim.min';
 import domify from './libs/domify';
 
 import markUnread from './libs/mark-unread';

src/libs/copy-file-path.js

@@ -1,6 +1,5 @@
 import copyToClipboard from 'copy-text-to-clipboard';
 import select from 'select-dom';
-import $ from './vendor/jquery.slim.min';
 
 function addFilePathCopyBtn() {
 	const $files = $('#files .file');

src/libs/copy-file.js

@@ -1,6 +1,5 @@
 import copyToClipboard from 'copy-text-to-clipboard';
 import select from 'select-dom';
-import $ from './vendor/jquery.slim.min';
 
 export default () => {
 	// Button already added (partial page nav), or non-text file

src/libs/copy-gist.js

@@ -1,6 +1,5 @@
 import copyToClipboard from 'copy-text-to-clipboard';
 import select from 'select-dom';
-import $ from './vendor/jquery.slim.min';
 
 export default () => {
 	// Button already added (partial page nav), or non-text file

src/libs/diffheader.js

@@ -1,6 +1,5 @@
 import debounce from 'debounce-fn';
 import select from 'select-dom';
-import $ from './vendor/jquery.slim.min';
 
 const diffFile = (() => {
 	let lastFile;

src/libs/mark-unread.js

@@ -1,6 +1,5 @@
 import gitHubInjection from 'github-injection';
 import select from 'select-dom';
-import $ from './vendor/jquery.slim.min';
 import * as icons from './icons';
 import * as pageDetect from './page-detect';
 

src/libs/reactions-avatars.js

@@ -1,5 +1,3 @@
-import $ from './vendor/jquery.slim.min';
-
 function add(currentUser) {
 	$('.comment-reactions.has-reactions').each((index, reactionsContainer) => {
 		const $reactionsContainer = $(reactionsContainer);

src/libs/show-names.js

@@ -1,5 +1,3 @@
-import $ from './vendor/jquery.slim.min';
-
 const storageKey = 'cachedNames';
 
 const getCachedUsers = cb => {

src/libs/upload-button.js

@@ -1,4 +1,3 @@
-import $ from './vendor/jquery.slim.min';
 import * as icons from './icons';
 import * as pageDetect from './page-detect';