dont assume recursive function calls have side-effects

src/ast/nodes/shared/callHasEffects.js

@@ -6,7 +6,7 @@ import { UNKNOWN } from '../../values.js';
 const currentlyCalling = new Set();
 
 function fnHasEffects ( fn ) {
-	if ( currentlyCalling.has( fn ) ) return true; // prevent infinite loops... TODO there must be a better way
+	if ( currentlyCalling.has( fn ) ) return false; // prevent infinite loops... TODO there must be a better way
 	currentlyCalling.add( fn );
 
 	// handle body-less arrow functions

test/form/self-calling-function-with-effects/_config.js

@@ -0,0 +1,3 @@
+module.exports = {
+	description: 'discards a self-calling function with side-effects'
+};

test/form/self-calling-function-with-effects/_expected/amd.js

@@ -0,0 +1,20 @@
+define(function () { 'use strict';
+
+	function foo ( x ) {
+		effect( x );
+		if ( x > 0 ) foo( x - 1 );
+	}
+
+	function bar ( x ) {
+		effect( x );
+		if ( x > 0 ) baz( x );
+	}
+
+	function baz ( x ) {
+		bar( x - 1 );
+	}
+
+	foo( 10 );
+	bar( 10 );
+
+});

test/form/self-calling-function-with-effects/_expected/cjs.js

@@ -0,0 +1,18 @@
+'use strict';
+
+function foo ( x ) {
+	effect( x );
+	if ( x > 0 ) foo( x - 1 );
+}
+
+function bar ( x ) {
+	effect( x );
+	if ( x > 0 ) baz( x );
+}
+
+function baz ( x ) {
+	bar( x - 1 );
+}
+
+foo( 10 );
+bar( 10 );

test/form/self-calling-function-with-effects/_expected/es.js

@@ -0,0 +1,16 @@
+function foo ( x ) {
+	effect( x );
+	if ( x > 0 ) foo( x - 1 );
+}
+
+function bar ( x ) {
+	effect( x );
+	if ( x > 0 ) baz( x );
+}
+
+function baz ( x ) {
+	bar( x - 1 );
+}
+
+foo( 10 );
+bar( 10 );

test/form/self-calling-function-with-effects/_expected/iife.js

@@ -0,0 +1,21 @@
+(function () {
+	'use strict';
+
+	function foo ( x ) {
+		effect( x );
+		if ( x > 0 ) foo( x - 1 );
+	}
+
+	function bar ( x ) {
+		effect( x );
+		if ( x > 0 ) baz( x );
+	}
+
+	function baz ( x ) {
+		bar( x - 1 );
+	}
+
+	foo( 10 );
+	bar( 10 );
+
+}());

test/form/self-calling-function-with-effects/_expected/umd.js

@@ -0,0 +1,24 @@
+(function (global, factory) {
+	typeof exports === 'object' && typeof module !== 'undefined' ? factory() :
+	typeof define === 'function' && define.amd ? define(factory) :
+	(factory());
+}(this, (function () { 'use strict';
+
+	function foo ( x ) {
+		effect( x );
+		if ( x > 0 ) foo( x - 1 );
+	}
+
+	function bar ( x ) {
+		effect( x );
+		if ( x > 0 ) baz( x );
+	}
+
+	function baz ( x ) {
+		bar( x - 1 );
+	}
+
+	foo( 10 );
+	bar( 10 );
+
+})));

test/form/self-calling-function-with-effects/main.js

@@ -0,0 +1,16 @@
+function foo ( x ) {
+	effect( x );
+	if ( x > 0 ) foo( x - 1 );
+}
+
+function bar ( x ) {
+	effect( x );
+	if ( x > 0 ) baz( x );
+}
+
+function baz ( x ) {
+	bar( x - 1 );
+}
+
+foo( 10 );
+bar( 10 );

test/form/self-calling-function/_config.js

@@ -0,0 +1,3 @@
+module.exports = {
+	description: 'discards a self-calling function without side-effects'
+};

test/form/self-calling-function/_expected/amd.js

@@ -0,0 +1,5 @@
+define(function () { 'use strict';
+
+
+
+});

test/form/self-calling-function/_expected/cjs.js

@@ -0,0 +1,2 @@
+'use strict';
+

test/form/self-calling-function/_expected/iife.js

@@ -0,0 +1,6 @@
+(function () {
+	'use strict';
+
+
+
+}());

test/form/self-calling-function/_expected/umd.js

@@ -0,0 +1,9 @@
+(function (global, factory) {
+	typeof exports === 'object' && typeof module !== 'undefined' ? factory() :
+	typeof define === 'function' && define.amd ? define(factory) :
+	(factory());
+}(this, (function () { 'use strict';
+
+
+
+})));

test/form/self-calling-function/main.js

@@ -0,0 +1,14 @@
+function foo ( x ) {
+	if ( x > 0 ) foo( x - 1 );
+}
+
+function bar ( x ) {
+	if ( x > 0 ) baz( x );
+}
+
+function baz ( x ) {
+	bar( x - 1 );
+}
+
+foo( 10 );
+bar( 10 );