Browse Source

Include line & column number in warning message

legacy-quote-reserved-properties
Daniel K 8 years ago
parent
commit
b164a46363
  1. 5
      src/ast/nodes/ThisExpression.js
  2. 1
      test/function/warn-on-top-level-this/_config.js
  3. 2
      test/function/warn-on-top-level-this/main.js

5
src/ast/nodes/ThisExpression.js

@ -1,4 +1,5 @@
import Node from '../Node.js'; import Node from '../Node.js';
import getLocation from '../../utils/getLocation.js';
export default class ThisExpression extends Node { export default class ThisExpression extends Node {
initialise ( scope ) { initialise ( scope ) {
@ -7,7 +8,9 @@ export default class ThisExpression extends Node {
if ( lexicalBoundary.isModuleScope ) { if ( lexicalBoundary.isModuleScope ) {
this.alias = this.module.bundle.context; this.alias = this.module.bundle.context;
if ( this.alias === 'undefined' ) { if ( this.alias === 'undefined' ) {
this.module.bundle.onwarn( `The 'this' keyword is equivalent to 'undefined' at the top level of an ES module, and has been rewritten (in ${this.module.id})` ); const location = getLocation(this.module.code, this.module.ast.end);
const detail = `${this.module.id}, line: ${location.line}, column: ${location.column}`;
this.module.bundle.onwarn( `The 'this' keyword is equivalent to 'undefined' at the top level of an ES module, and has been rewritten (in ${detail})`);
} }
} }
} }

1
test/function/warn-on-top-level-this/_config.js

@ -7,6 +7,7 @@ module.exports = {
assert.equal(warnings.length, 1); assert.equal(warnings.length, 1);
assert.equal(warnings[0].indexOf(message), 0); assert.equal(warnings[0].indexOf(message), 0);
assert(warnings[0].match(/\(in.*warn-on-top-level-this.*\)/)); assert(warnings[0].match(/\(in.*warn-on-top-level-this.*\)/));
assert(warnings[0].match(/line: 4, column: 0/));
}, },
runtimeError: err => { runtimeError: err => {
assert.equal( err.message, `Cannot set property 'foo' of undefined` ); assert.equal( err.message, `Cannot set property 'foo' of undefined` );

2
test/function/warn-on-top-level-this/main.js

@ -1 +1,3 @@
const someVariableJustToCheckOnCorrectLineNumber = true; // eslint-disable-line
this.foo = 'bar'; this.foo = 'bar';

Loading…
Cancel
Save