FIX: test for legacy; remove Object.define for legacy

bin/src/index.js

@@ -16,6 +16,7 @@ const command = minimist( process.argv.slice( 2 ), {
 		g: 'globals',
 		h: 'help',
 		i: 'input',
+		l: 'legacy',
 		m: 'sourcemap',
 		n: 'name',
 		o: 'output',

bin/src/runRollup.js

@@ -105,6 +105,7 @@ const equivalents = {
 	indent: 'indent',
 	input: 'entry',
 	intro: 'intro',
+	legacy: 'legacy',
 	name: 'moduleName',
 	output: 'dest',
 	outro: 'outro',

src/finalisers/amd.js

@@ -27,7 +27,7 @@ export default function amd ( bundle, magicString, { exportMode, indentString, i
 
 	const exportBlock = getExportBlock( bundle.entryModule, exportMode );
 	if ( exportBlock ) magicString.append( '\n\n' + exportBlock );
-	if ( exportMode === 'named' ) magicString.append( `\n\n${esModuleExport}` );
+	if ( exportMode === 'named' && options.legacy !== true ) magicString.append( `\n\n${esModuleExport}` );
 	if ( options.outro ) magicString.append( `\n${options.outro}` );
 
 	return magicString

src/finalisers/cjs.js

@@ -3,7 +3,7 @@ import esModuleExport from './shared/esModuleExport.js';
 
 export default function cjs ( bundle, magicString, { exportMode, intro }, options ) {
 	intro = ( options.useStrict === false ? intro : `'use strict';\n\n${intro}` ) +
-	        ( exportMode === 'named' ? `${esModuleExport}\n\n` : '' );
+	        ( exportMode === 'named' && options.legacy !== true ? `${esModuleExport}\n\n` : '' );
 
 	let needsInterop = false;
 

src/finalisers/umd.js

@@ -73,7 +73,7 @@ export default function umd ( bundle, magicString, { exportMode, indentString, i
 
 	const exportBlock = getExportBlock( bundle.entryModule, exportMode );
 	if ( exportBlock ) magicString.append( '\n\n' + exportBlock );
-	if ( exportMode === 'named' ) magicString.append( `\n\n${esModuleExport}` );
+	if ( exportMode === 'named' && options.legacy !== true ) magicString.append( `\n\n${esModuleExport}` );
 	if ( options.outro ) magicString.append( `\n${options.outro}` );
 
 	return magicString

test/form/legacy/_config.js

@@ -1,6 +1,7 @@
 module.exports = {
-	description: 'supports environments without Object.freeze',
+	description: 'supports environments without Object.freeze, Object.defined',
 	options: {
+    moduleName: 'myBundle',
 		legacy: true
 	}
 };

test/form/legacy/_expected/amd.js

@@ -1,13 +1,20 @@
-define(function () { 'use strict';
+define(['exports'], function (exports) { 'use strict';
 
-	const foo = 42;
+	const foo = 1;
+	const bar = 2;
 
 
 	var namespace = (Object.freeze || Object)({
-		foo: foo
+		foo: foo,
+		bar: bar
 	});
 
-	const x = 'foo';
+	console.log( Object.keys( namespace ) );
-	assert.equal( namespace[x], 42 );
+
+	const a = 1;
+	const b = 2;
+
+	exports.a = a;
+	exports.b = b;
 
 });

test/form/legacy/_expected/cjs.js

@@ -1,11 +1,18 @@
 'use strict';
 
-const foo = 42;
+const foo = 1;
+const bar = 2;
 
 
 var namespace = (Object.freeze || Object)({
-	foo: foo
+	foo: foo,
+	bar: bar
 });
 
-const x = 'foo';
+console.log( Object.keys( namespace ) );
-assert.equal( namespace[x], 42 );
+
+const a = 1;
+const b = 2;
+
+exports.a = a;
+exports.b = b;

test/form/legacy/_expected/es.js

@@ -1,9 +1,15 @@
-const foo = 42;
+const foo = 1;
+const bar = 2;
 
 
 var namespace = (Object.freeze || Object)({
-	foo: foo
+	foo: foo,
+	bar: bar
 });
 
-const x = 'foo';
+console.log( Object.keys( namespace ) );
-assert.equal( namespace[x], 42 );
+
+const a = 1;
+const b = 2;
+
+export { a, b };

test/form/legacy/_expected/iife.js

@@ -1,14 +1,21 @@
-(function () {
+(function (exports) {
 	'use strict';
 
-	const foo = 42;
+	const foo = 1;
+	const bar = 2;
 
 
 	var namespace = (Object.freeze || Object)({
-		foo: foo
+		foo: foo,
+		bar: bar
 	});
 
-	const x = 'foo';
+	console.log( Object.keys( namespace ) );
-	assert.equal( namespace[x], 42 );
 
-}());
+	const a = 1;
+	const b = 2;
+
+	exports.a = a;
+	exports.b = b;
+
+}((this.myBundle = this.myBundle || {})));

test/form/legacy/_expected/umd.js

@@ -1,17 +1,24 @@
 (function (global, factory) {
-	typeof exports === 'object' && typeof module !== 'undefined' ? factory() :
+	typeof exports === 'object' && typeof module !== 'undefined' ? factory(exports) :
-	typeof define === 'function' && define.amd ? define(factory) :
+	typeof define === 'function' && define.amd ? define(['exports'], factory) :
-	(factory());
+	(factory((global.myBundle = global.myBundle || {})));
-}(this, (function () { 'use strict';
+}(this, (function (exports) { 'use strict';
 
-	const foo = 42;
+	const foo = 1;
+	const bar = 2;
 
 
 	var namespace = (Object.freeze || Object)({
-		foo: foo
+		foo: foo,
+		bar: bar
 	});
 
-	const x = 'foo';
+	console.log( Object.keys( namespace ) );
-	assert.equal( namespace[x], 42 );
+
+	const a = 1;
+	const b = 2;
+
+	exports.a = a;
+	exports.b = b;
 
 })));

test/form/legacy/main.js

@@ -1,4 +1,6 @@
 import * as namespace from './namespace.js';
 
-const x = 'foo';
+console.log( Object.keys( namespace ) );
-assert.equal( namespace[x], 42 );
+
+export const a = 1;
+export const b = 2;

test/form/legacy/namespace.js

@@ -1 +1,2 @@
-export const foo = 42;
+export const foo = 1;
+export const bar = 2;