account for local scopes when checking for pure global functions

src/utils/testForSideEffects.js

@@ -69,7 +69,8 @@ export default function testForSideEffects ( node, scope, statement, strongDepen
 					if ( flattened ) {
 						// if we're calling e.g. Object.keys(thing), there are no side-effects
 						// TODO make pureFunctions configurable
-						const declaration = statement.module.trace( flattened.name );
+						const declaration = scope.findDeclaration( flattened.name ) || statement.module.trace( flattened.name );
+
 						if ( !!declaration || !pureFunctions[ flattened.keypath ] ) {
 							hasSideEffect = true;
 						}

test/form/side-effect-e/_config.js

@@ -1,6 +1,5 @@
 module.exports = {
-	solo: true,
+	description: 'excludes functions that are known to be pure',
-	description: 'disregards side-effects that are contained within a function',
 	options: {
 		moduleName: 'myBundle'
 	}

test/form/side-effect-e/_expected/amd.js

@@ -1,5 +1,18 @@
 define(function () { 'use strict';
 
+	function foo () {
+		var Object = {
+			keys: function () {
+				console.log( 'side-effect' );
+			}
+		};
+
+		var obj = { foo: 1, bar: 2 };
+		var keys = Object.keys( obj );
+	}
+
+	foo();
+
 	var main = 42;
 
 	return main;

test/form/side-effect-e/_expected/cjs.js

@@ -1,5 +1,18 @@
 'use strict';
 
+function foo () {
+	var Object = {
+		keys: function () {
+			console.log( 'side-effect' );
+		}
+	};
+
+	var obj = { foo: 1, bar: 2 };
+	var keys = Object.keys( obj );
+}
+
+foo();
+
 var main = 42;
 
 module.exports = main;

test/form/side-effect-e/_expected/es6.js

@@ -1,3 +1,16 @@
+function foo () {
+	var Object = {
+		keys: function () {
+			console.log( 'side-effect' );
+		}
+	};
+
+	var obj = { foo: 1, bar: 2 };
+	var keys = Object.keys( obj );
+}
+
+foo();
+
 var main = 42;
 
 export default main;

test/form/side-effect-e/_expected/iife.js

@@ -1,5 +1,18 @@
 var myBundle = (function () { 'use strict';
 
+	function foo () {
+		var Object = {
+			keys: function () {
+				console.log( 'side-effect' );
+			}
+		};
+
+		var obj = { foo: 1, bar: 2 };
+		var keys = Object.keys( obj );
+	}
+
+	foo();
+
 	var main = 42;
 
 	return main;

test/form/side-effect-e/_expected/umd.js

@@ -4,6 +4,19 @@
 	global.myBundle = factory();
 }(this, function () { 'use strict';
 
+	function foo () {
+		var Object = {
+			keys: function () {
+				console.log( 'side-effect' );
+			}
+		};
+
+		var obj = { foo: 1, bar: 2 };
+		var keys = Object.keys( obj );
+	}
+
+	foo();
+
 	var main = 42;
 
 	return main;

test/form/side-effect-e/main.js

@@ -1,6 +1,12 @@
 function foo () {
-	var a, b, c;
+	var Object = {
-	b = 1;
+		keys: function () {
+			console.log( 'side-effect' );
+		}
+	};
+
+	var obj = { foo: 1, bar: 2 };
+	var keys = Object.keys( obj );
 }
 
 foo();