rgbds: use our LDFLAGS, and clean up build.sh a bit (#4964)

packages/rgbds/Makefile.patch

@@ -1,20 +1,29 @@
-diff -u -r ../rgbds-0.3.8/Makefile ./Makefile
+--- ../Makefile.orig	2019-11-01 17:25:45.000000000 +0100
---- ../rgbds-0.3.8/Makefile	2018-12-10 23:19:36.000000000 +0000
++++ ./Makefile	2020-02-23 21:55:43.646881105 +0100
-+++ ./Makefile	2019-03-10 21:52:48.763105448 +0000
+@@ -11,11 +11,9 @@
-@@ -11,7 +11,7 @@
+ 
- Q		:= @
+ # User-defined variables
- PREFIX		:= /usr/local
+ 
+-Q		:= @
+-PREFIX		:= /usr/local
  bindir		:= ${PREFIX}/bin
--mandir		:= ${PREFIX}/man
+ mandir		:= ${PREFIX}/man
-+mandir		:= ${PREFIX}/share/man
+-STRIP		:= -s
- STRIP		:= -s
++STRIP		:=
  BINMODE		:= 555
  MANMODE		:= 444
-@@ -29,7 +29,6 @@
+ CHECKPATCH	:= ../linux/scripts/checkpatch.pl
+@@ -31,13 +29,9 @@
+ 
  WARNFLAGS	:= -Wall
  
- # Overridable CFLAGS
+-# Overridable CFLAGS
 -CFLAGS		:= -g
  # Non-overridable CFLAGS
  REALCFLAGS	:= ${CFLAGS} ${WARNFLAGS} -std=c99 -D_POSIX_C_SOURCE=200809L \
  		   -Iinclude -DBUILD_VERSION_STRING=\"${VERSION_STRING}\"
+-# Overridable LDFLAGS
+-LDFLAGS		:=
+ # Non-overridable LDFLAGS
+ REALLDFLAGS	:= ${LDFLAGS} ${WARNFLAGS}
+ 

packages/rgbds/build.sh

@@ -2,12 +2,9 @@ TERMUX_PKG_HOMEPAGE=https://rednex.github.io/rgbds/
 TERMUX_PKG_DESCRIPTION="Rednex Game Boy Development System"
 TERMUX_PKG_LICENSE="MIT"
 TERMUX_PKG_VERSION=0.3.9
+TERMUX_PKG_REVISION=1
 TERMUX_PKG_SRCURL=https://github.com/rednex/rgbds/releases/download/v${TERMUX_PKG_VERSION}/rgbds-${TERMUX_PKG_VERSION}.tar.gz
 TERMUX_PKG_SHA256=e58af4aa548b2a6f799da8db6ea951e2dbbc7a70a56b7539a0eea80e2b0dbbf3
 TERMUX_PKG_DEPENDS="libpng, zlib"
 TERMUX_PKG_BUILD_IN_SRC=true
-TERMUX_PKG_EXTRA_MAKE_ARGS="PREFIX=${TERMUX_PREFIX} Q= STRIP="
 
-termux_step_pre_configure() {
-	CFLAGS+=" $LDFLAGS"
-}