Fredrik Fornwall
9 years ago
5 changed files with 27 additions and 91 deletions
@ -1,35 +0,0 @@ |
|||
Following compiler warning: |
|||
|
|||
/home/fornwall/termux/mc/src/lib/vfs/interface.c: In function 'mc_open': |
|||
/home/fornwall/termux/mc/src/lib/vfs/interface.c:203:28: warning: 'mode_t' is promoted to 'int' when passed through '...' |
|||
mode = va_arg (ap, mode_t); |
|||
^ |
|||
/home/fornwall/termux/mc/src/lib/vfs/interface.c:203:28: note: (so you should pass 'int' not 'mode_t' to 'va_arg') |
|||
/home/fornwall/termux/mc/src/lib/vfs/interface.c:203:28: note: if this code is reached, the program will abort |
|||
|
|||
which causes crash on arm devices due to mode_t being unsigned int. |
|||
|
|||
diff -u -r ../mc-4.8.16/lib/vfs/interface.c ./lib/vfs/interface.c
|
|||
--- ../mc-4.8.16/lib/vfs/interface.c 2016-03-12 10:45:47.000000000 -0500
|
|||
+++ ./lib/vfs/interface.c 2016-03-14 22:03:41.417524612 -0400
|
|||
@@ -200,7 +200,7 @@
|
|||
{ |
|||
va_list ap; |
|||
va_start (ap, flags); |
|||
- mode = va_arg (ap, mode_t);
|
|||
+ mode = (mode_t) va_arg (ap, unsigned int);
|
|||
va_end (ap); |
|||
} |
|||
|
|||
diff -u -r ../mc-4.8.16/src/editor/editcmd.c ./src/editor/editcmd.c
|
|||
--- ../mc-4.8.16/src/editor/editcmd.c 2016-03-12 10:45:47.000000000 -0500
|
|||
+++ ./src/editor/editcmd.c 2016-03-14 22:03:02.094128021 -0400
|
|||
@@ -301,7 +301,7 @@
|
|||
(void) mc_chown (savename_vpath, edit->stat1.st_uid, edit->stat1.st_gid); |
|||
(void) mc_chmod (savename_vpath, edit->stat1.st_mode); |
|||
|
|||
- fd = mc_open (savename_vpath, O_CREAT | O_WRONLY | O_TRUNC | O_BINARY, edit->stat1.st_mode);
|
|||
+ fd = mc_open (savename_vpath, O_CREAT | O_WRONLY | O_TRUNC | O_BINARY, (unsigned int) edit->stat1.st_mode);
|
|||
if (fd == -1) |
|||
goto error_save; |
|||
|
@ -1,34 +0,0 @@ |
|||
From e274e58cb7dff1683480f5538fd1bfa41a85c0c7 Mon Sep 17 00:00:00 2001 |
|||
From: Andreas Mohr <and@gmx.li> |
|||
Date: Sun, 13 Mar 2016 20:59:47 +0000 |
|||
Subject: [PATCH] Fish: fix perl ls helper |
|||
|
|||
With #3599 I introduce a perl warning in fish_list_perl() |
|||
so fish_list_perl() was skipped (return code 255) and fallback ls |
|||
function was used instead. |
|||
|
|||
Plus all % chars must quoted because of g_strconcat() after reading |
|||
script file into string. |
|||
|
|||
Fix it! |
|||
|
|||
Signed-off-by: Andreas Mohr <and@gmx.li> |
|||
---
|
|||
src/vfs/fish/helpers/ls | 4 ++-- |
|||
1 file changed, 2 insertions(+), 2 deletions(-) |
|||
|
|||
diff --git a/src/vfs/fish/helpers/ls b/src/vfs/fish/helpers/ls
|
|||
index 1284e17..909a77d 100755
|
|||
--- a/src/vfs/fish/helpers/ls
|
|||
+++ b/src/vfs/fish/helpers/ls
|
|||
@@ -138,8 +138,8 @@ while((my $filename = readdir (DIR))){
|
|||
my $linkname = readlink ("$dirname/$filename"); |
|||
$linkname =~ $strutils_shell_escape_regex; |
|||
printf("R%%o %%o $uid.$gid\nS$size\nd$mloctime\n:\"%%s\" -> \"%%s\"\n\n", S_IMODE($mode), S_IFMT($mode), $e_filename, $linkname); |
|||
- } elseif (S_ISCHR ($mode) || S_ISBLK ($mode)) {
|
|||
- my $minor = $rdev % 256;
|
|||
+ } elsif (S_ISCHR ($mode) || S_ISBLK ($mode)) {
|
|||
+ my $minor = $rdev %% 256;
|
|||
my $major = int( $rdev / 256 ); |
|||
printf("R%%o %%o $uid.$gid\nE$major,$minor\nd$mloctime\n:\"%%s\"\n\n", S_IMODE($mode), S_IFMT($mode), $e_filename); |
|||
} else { |
Loading…
Reference in new issue