Turns out it's pretty easy to implement. Now the buffer queue will
stop requesting for data once the sink is suspended on idle. No
more power wasted.
Note that it is natural that there would be a bit of extra delay
when resume playback after the sink is suspended. In case it is
wanted to be avoided, make sure the module-suspend-on-idle is not
loaded.
This should work way better than the old code, as it makes use of
the buffer queue callback to do Enqueue(), which might be the only
nice/right way to use OpenSLES on Android. CPU usage is low and
RAM usage seems reasonable. No memory leak noticed. Tested with
mpv on my Oreo phone (wired and Bluetooth).
The latency was chosen base on Bluetooth audio requirement on Oreo.
Shouldn't be hard to make it configurable as a module param in the
future.
The new code has a known downside though, that is it doesn't really
support sink suspension, as in, silence will kept being written
to the audio device even when the sink is suspended, which may have
certain impact to battery time.
It's probably possible to catch the state change of the sink and
notify the buffer queue about it. It's just I don't want to bother
digging further at the moment.
* update ndk to 17
* bump NDK version in setup-android script
* libnl: fix for ndk r17
* libpixman: use clang's __builtin_shufflevector instead of __builtin_shuffle (#1)
Required to make package build with ndk17.
* fix as for arm
* ndk17 still uses ld.bfd on aarch64
* use -fno-integrated-as for clang only
* glib: remove patch unnecessary after ndk17
* torsocks: remove unneeded patch after ndk17
* subversion: fix build as clang++ now errors out for mismatched flags
* libpulseaudio: fix build with ndk17
https://github.com/termux/termux-packages/pull/2415#issuecomment-388296684
* gst-plugins-good: disable video4linux2
ioctl is defined as __overloadable in ndk17 headers which
conflicts with v4l2object's member ioctl
* libzmq: disable Werror to build with ndk17
* ltrace: hardcode symbol not available in ndk17
* busybox: build with clang for all arches except arm
* dropbear: build with clang instead of gcc
* gnupg: build with clang instead of gcc
* openssl: use clang for all arches except arm
* picolisp: build with clang instead of gcc
* valgrind: use clang on all arches except aarch64
* Revert "gst-plugins-good: disable video4linux2"
This reverts commit 43850b81ccf60033c25cb13dfd326c1b0528773a.
Already applied on base branch.
* libllvm: use default arm triple
Fredrik Fornwall
tomty89
Henrik Grimler
Vishal Biswas
its-pointless
its-pointless
Stephen
Henrik Grimler
Alain Kalker