From 16d05b40cdaefeef5d4f269dd41ec7eb0789c84f Mon Sep 17 00:00:00 2001 From: Ben Woosley Date: Wed, 10 Jan 2018 02:52:37 -0800 Subject: [PATCH] fix(electron-settings): Drop ineffectual nodeintegration setting The actual nodeintegration setting is nested under webPreferences: https://github.com/electron/electron/blob/master/docs/api/browser-window.md#new-browserwindowoptions If you set it there, Zap doesn't run, because process is no longer available in app.html. Use of process in app.html is a barrier to other security settings - sandbox and contextIsolation. https://github.com/electron/electron/blob/master/docs/tutorial/security.md#checklist --- app/main.dev.js | 1 - 1 file changed, 1 deletion(-) diff --git a/app/main.dev.js b/app/main.dev.js index c1560a05..43a1ea50 100644 --- a/app/main.dev.js +++ b/app/main.dev.js @@ -82,7 +82,6 @@ app.on('ready', async () => { mainWindow = new BrowserWindow({ show: false, frame: false, - nodeIntegration: false, icon: icon })