From 274768d3c23c0e8a89ff8b938062d43524c1676d Mon Sep 17 00:00:00 2001 From: Ben Woosley Date: Wed, 3 Jan 2018 17:16:38 -0800 Subject: [PATCH 1/2] enhance(dependencies): Drop node 7 support And declare minimum versions in package.json. Node 7 was a dev release and is defunct now that 8 is LTS and 9 is the current dev release. If we wanted to support earlier versions, we should go all the way back to the prior LTS release series, 6, but I don't see a reason to do that for new software. Bump to npm 5 because that is the version that was released with node 8: https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V8.md#8.0.0 This was prompted by the fact that current versions of yarn have dropped node 7 support. https://yarnpkg.com/en/ --- .babelrc | 2 +- README.md | 2 +- package.json | 4 ++++ 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.babelrc b/.babelrc index cc472537..eb7a40d8 100644 --- a/.babelrc +++ b/.babelrc @@ -2,7 +2,7 @@ "presets": [ ["env", { "targets": { - "node": 7, + "node": 8, "browsers": "electron 1.7" }, "useBuiltIns": true diff --git a/README.md b/README.md index 18b9c39a..a645dc1f 100644 --- a/README.md +++ b/README.md @@ -15,7 +15,7 @@ Join us on [slack](https://join.slack.com/t/zaphq/shared_invite/enQtMjkyNTAxNDA3 ## Requirements -* **Node.js version >= 7, npm version >= 4 and [yarn](https://yarnpkg.com/lang/en/docs/install/)** +* **Node.js version >= 8, npm version >= 5 and [yarn](https://yarnpkg.com/lang/en/docs/install/)** ## Install diff --git a/package.json b/package.json index e00d0be7..a263e257 100644 --- a/package.json +++ b/package.json @@ -33,6 +33,10 @@ "install-grpc": "cd app && npm run install-grpc" }, "browserslist": "electron 1.7", + "engines": { + "node": ">=8.0.0", + "npm": ">=5.0.0" + }, "build": { "productName": "ZapDesktop", "appId": "org.develar.ZapDesktop", From ae2b2a98146807209bae5b01718e789800ec47e0 Mon Sep 17 00:00:00 2001 From: Ben Woosley Date: Tue, 2 Jan 2018 00:48:55 -0800 Subject: [PATCH 2/2] enhance(ci): Test on node 8 and the lastest stable release Because yarn no longer supports node 7: warning You are using Node "7.10.1" which is not supported and may encounter bugs or unexpected behavior. Yarn supports the following semver range: "^4.8.0 || ^5.7.0 || ^6.2.2 || >=8.0.0" --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index fa0f434c..b6114188 100644 --- a/.travis.yml +++ b/.travis.yml @@ -7,8 +7,8 @@ env: - TEST=test-ci node_js: + - node - 8 - - 7 cache: apt: true